Improve error message when scm element is missing from a child pom

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Component/s: Web - UI
  • Labels:
    None
  • Complexity:
    Intermediate

Description

When adding a multi-module project, if one of the child projects does not have a scm element, I still get the generic message:

"Missing 'scm' element in the POM."

In the log file, I can see that it knows exactly which pom is missing the element:

INFO | jvm 1 | 2008/02/25 11:16:35 | 2008-02-25 11:16:35,530 [SocketListener0-7] ERROR MavenBuilderHelper:default - Missing 'scm' element in the ExampleWebapp POM.

(This happened because the child project did not have a <parent> element.)

The web page should display the more specific error message.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

You mean we have to display "Missing 'scm' element in the POM ${moduleName}." ?

Show
Olivier Lamy added a comment - You mean we have to display "Missing 'scm' element in the POM ${moduleName}." ?
Hide
Permalink
Emmanuel Venisse added a comment -

yes, I think

Show
Emmanuel Venisse added a comment - yes, I think
Hide
Permalink
Olivier Lamy added a comment -

fixed in rev 668330.

Show
Olivier Lamy added a comment - fixed in rev 668330.
Hide
Permalink
Wendy Smoak added a comment -

When I attempt to add a project that does not have a scm element, I get this message:

Missing 'scm' element in the POM, projet {0}

Show
Wendy Smoak added a comment - When I attempt to add a project that does not have a scm element, I get this message: Missing 'scm' element in the POM, projet {0}
Hide
Permalink
Wendy Smoak added a comment -

The "Missing 'scm' element in the POM, projet {0}" message is happening when the scm information is completely missing from the project. (No scm element in the parent pom I'm trying to add using a url.)

That's different from the original issue here, which was about the scm element missing from a child pom.

However, I think the broken message is related to the fix for this issue. Let me know if you want me to open a separate JIRA for it.

Show
Wendy Smoak added a comment - The "Missing 'scm' element in the POM, projet {0}" message is happening when the scm information is completely missing from the project. (No scm element in the parent pom I'm trying to add using a url.) That's different from the original issue here, which was about the scm element missing from a child pom. However, I think the broken message is related to the fix for this issue. Let me know if you want me to open a separate JIRA for it.
Hide
Permalink
Olivier Lamy added a comment -

rev 696497 should fix that.
Wendy can you test it ? And close the issue if it's fine ? (I think yes )

Show
Olivier Lamy added a comment - rev 696497 should fix that. Wendy can you test it ? And close the issue if it's fine ? (I think yes )
Hide
Permalink
Olivier Lamy added a comment -

fixed

Show
Olivier Lamy added a comment - fixed

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Wendy Smoak
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: