Continuum (moved to ASF)
  1. Continuum (moved to ASF)
  2. CONTINUUM-1640

No changes and no committer name extracted from SVN

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.1
    • Fix Version/s: 1.4.1
    • Component/s: SCM
    • Labels:
      None
    • Environment:
      Windows XP, Java 1.5, SVN 1.4.3
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      When continuum detects changes and makes builds, no data is extracted on change date and committer.

      It always looks like this

      ****************************************************************************
      SCM Changes:
      ****************************************************************************
      Changed: no author @ no date
      Comment: no comment
      Files changed:
      (here are files)

      It is the same machine (SVN/continuum) so we rule out ime difference immediately.

      Moreover I've checked in continuum logs, there is "svn --non-interactive log" command executed, and when I type this command in, proper dates and commiters are displayed.

      looking at org.apache.maven.continuum.scm.DefaultContinuumScm, I've found that change date/commiters are taken from ScmResult that comes from this method
      scmResult = scmManager.getProviderByRepository( repository ).update( repository, fileSet, tag, getLatestUpdateDate( project ) );
      result = convertScmResult( scmResult );

      Maven SVN SCM Manager returns no changes in scmResult.getChanges()

      Where this svn log command is coming from then? Not from Maven SCM but from continuum itself?

        Activity

        Hide
        Brett Porter added a comment -

        pushing out, but we should be able to measure against a single time source

        Show
        Brett Porter added a comment - pushing out, but we should be able to measure against a single time source
        Hide
        Immanuel Scheerer added a comment -

        I stepped into the same problem because our LDAP users contain a space character. The current regular expressions from the project "maven-scm-provider-svnexec" used to parse the svn log do not match when the author contains a space. I will attach the fix that works for me.

        Show
        Immanuel Scheerer added a comment - I stepped into the same problem because our LDAP users contain a space character. The current regular expressions from the project "maven-scm-provider-svnexec" used to parse the svn log do not match when the author contains a space. I will attach the fix that works for me.
        Hide
        Immanuel Scheerer added a comment - - edited

        Attached the fix that works for me.

        Show
        Immanuel Scheerer added a comment - - edited Attached the fix that works for me.
        Hide
        Brent N Atkinson added a comment -

        It appears that this issue was already taken care of with an upgrade of maven-scm. This is consistent with the contents of the patch, which includes code for maven-scm classes and not Continuum's.

        The issue was also reported as SCM-455 to the maven-scm project and according to Jira it was fixed in maven-scm 1.3. The first release bundling a version of maven-scm greater than 1.3 was Continuum 1.4.1, which uses maven-scm 1.4.

        I adapted the test case and added to continuum-scm just to verify that the issue is fixed. I had to change the changelog format for the first entry however, because it no longer appears to parse with modern versions of Subversion. This should not affect the outcome for author parsing, but it is worth noting that the test case is not identical.

        Show
        Brent N Atkinson added a comment - It appears that this issue was already taken care of with an upgrade of maven-scm. This is consistent with the contents of the patch, which includes code for maven-scm classes and not Continuum's. The issue was also reported as SCM-455 to the maven-scm project and according to Jira it was fixed in maven-scm 1.3. The first release bundling a version of maven-scm greater than 1.3 was Continuum 1.4.1, which uses maven-scm 1.4. I adapted the test case and added to continuum-scm just to verify that the issue is fixed. I had to change the changelog format for the first entry however, because it no longer appears to parse with modern versions of Subversion. This should not affect the outcome for author parsing, but it is worth noting that the test case is not identical.
        Hide
        Brent N Atkinson added a comment -

        I am setting the fix version to 1.4.1 since that is when the issue was actually fixed. The test has been applied to trunk@r1654973.

        Show
        Brent N Atkinson added a comment - I am setting the fix version to 1.4.1 since that is when the issue was actually fixed. The test has been applied to trunk@r1654973.

          People

          • Assignee:
            Brent N Atkinson
            Reporter:
            Timur Evdokimov

            Dates

            • Created:
              Updated:
              Resolved: