Continuum
  1. Continuum
  2. CONTINUUM-1601

Email address with '+' is not accepted in mail notifier

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: Web - UI
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Description

      It's unable to add email address including '+' (like mike+notifier@somehost.com) for mail notifier (via " Add/Edit Mail Notifier" form). Displayed error "Address is invalid".
      The same email address can be added in other places like email address for user, so maybe it only problem with validation at WebUI level (not system wide restriction).

        Activity

        Hide
        Maria Catherine Tan added a comment -

        Is the "+" sign allowed anywhere in the local-part of the email address?

        Is +abc@host.com valid?

        Show
        Maria Catherine Tan added a comment - Is the "+" sign allowed anywhere in the local-part of the email address? Is +abc@host.com valid?
        Hide
        Marcin Zajaczkowski added a comment -

        I have never seen that email address, but according to Wikipedia [1] and RFC2822 [2], it could be allowed on some system (but I doubt it is). Nevertheless it's not for tagging purposes, so it's not scope of that bug. In other case "! # $ % * / ? | ^ { } ` ~ & ' + - = _" should be also added to that subset.

        Btw, after a lecture of mentioned pages I think that "-" should be also added as an allowed tag separator (together with "+").

        [1] - http://en.wikipedia.org/wiki/E-mail_address#Limitations
        [2] - http://tools.ietf.org/html/rfc2822

        Show
        Marcin Zajaczkowski added a comment - I have never seen that email address, but according to Wikipedia [1] and RFC2822 [2] , it could be allowed on some system (but I doubt it is). Nevertheless it's not for tagging purposes, so it's not scope of that bug. In other case "! # $ % * / ? | ^ { } ` ~ & ' + - = _" should be also added to that subset. Btw, after a lecture of mentioned pages I think that "-" should be also added as an allowed tag separator (together with "+"). [1] - http://en.wikipedia.org/wiki/E-mail_address#Limitations [2] - http://tools.ietf.org/html/rfc2822
        Hide
        Maria Catherine Tan added a comment -

        Attached patch.

        • used xwork's regex validator instead of email validator
        • reused expression used by the email validator and added the "+" sign to it.
        Show
        Maria Catherine Tan added a comment - Attached patch. used xwork's regex validator instead of email validator reused expression used by the email validator and added the "+" sign to it.
        Hide
        Emmanuel Venisse added a comment -

        Patch applied. Thanks.

        Show
        Emmanuel Venisse added a comment - Patch applied. Thanks.

          People

          • Assignee:
            Emmanuel Venisse
            Reporter:
            Marcin Zajaczkowski
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: