Continuum

should not be allowed to delete a build result that is still executing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-3
  • Fix Version/s: 1.1-beta-4
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

note that deleting the build result from on the build result page also seems to skip confirmation. All I did was hit the space bar...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

Sure we have to add a confirmation page for Delete Build Result(s)

Show
Olivier Lamy added a comment - Sure we have to add a confirmation page for Delete Build Result(s)
Hide
Permalink
Olivier Lamy added a comment -

add confirmation page before delete buildResult(s) (svn rev 581740)

Show
Olivier Lamy added a comment - add confirmation page before delete buildResult(s) (svn rev 581740)
Hide
Permalink
Emmanuel Venisse added a comment -

I'm not sure this issue is totally fixed. I think we need to not allow to delete a build result that is is running

Show
Emmanuel Venisse added a comment - I'm not sure this issue is totally fixed. I think we need to not allow to delete a build result that is is running
Hide
Permalink
Olivier Lamy added a comment -

Ok I see the point. We can check buildResult.state != ContinuumProjectState.BUILDING.
This will work except when the build has been cancelled.
In this case, I'm not sure we can know that and we must be able to delete this buildResult.
Idea ?

Show
Olivier Lamy added a comment - Ok I see the point. We can check buildResult.state != ContinuumProjectState.BUILDING. This will work except when the build has been cancelled. In this case, I'm not sure we can know that and we must be able to delete this buildResult. Idea ?
Hide
Permalink
Emmanuel Venisse added a comment -

It isn't enough to check the state, because in some case it is always set to BUILDING, for example if you restart Continuum during a build.
a build result is still executing if:

  • state = building
  • project/build definition of the build result is the current build
Show
Emmanuel Venisse added a comment - It isn't enough to check the state, because in some case it is always set to BUILDING, for example if you restart Continuum during a build. a build result is still executing if: state = building project/build definition of the build result is the current build
Hide
Permalink
Olivier Lamy added a comment -

fixed in rev 582423. (prevent user deleting buildResult currently building)

Show
Olivier Lamy added a comment - fixed in rev 582423. (prevent user deleting buildResult currently building)
Hide
Permalink
Olivier Lamy added a comment -

Warning message is not correct.

Show
Olivier Lamy added a comment - Warning message is not correct.
Hide
Permalink
Olivier Lamy added a comment -

warning message (rev 582978)

Show
Olivier Lamy added a comment - warning message (rev 582978)

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Brett Porter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: