Continuum

meta refresh causes build loop

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-1
  • Fix Version/s: 1.1-beta-2
  • Component/s: Web interface
  • Labels:
    None
  • Environment:
    all
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Simple scenario :

  • edit a project group
  • force a project build with the link "Build Now"
  • go to drink some coffe (longer than 5 minutes)
  • some project build have build enqueuing

It due to the link http://$

{ip}

:$

{pwd}

/continuum/buildProject.action?fromGroupPage=true&projectGroupId=15&projectId=79
The meta refresh force the build.
As some browser have the tabs, this can cause a lot of not needed builds .

–
Olivier
PS : I will provide a patch next week.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

read "the same project build have build enqueuing again" instead of "some project build have build enqueuing"

Show
Olivier Lamy added a comment - read "the same project build have build enqueuing again" instead of "some project build have build enqueuing"
Hide
Permalink
Jesse McConnell added a comment -

there is something in webwork that is suppose to address this actually, something regarding tokens I think it was...

think there was an interceptor that would eat the request if it had been submitted already

Show
Jesse McConnell added a comment - there is something in webwork that is suppose to address this actually, something regarding tokens I think it was... think there was an interceptor that would eat the request if it had been submitted already
Hide
Permalink
Emmanuel Venisse added a comment -

already fixed.

Show
Emmanuel Venisse added a comment - already fixed.
Hide
Permalink
Olivier Lamy added a comment -

Not fixed.
force a project build.
Shutdown your server and you will an error in your browser.

Show
Olivier Lamy added a comment - Not fixed. force a project build. Shutdown your server and you will an error in your browser.
Hide
Permalink
Emmanuel Venisse added a comment -

I don't understand. When I force a build on the project group page, and wait a long time, a new build isn't built a new time by the meta-refresh because we are on the projectGroupSummary.action and not the buildProject.action due to redirect, so it seems to be fixed. Do I miss something?

If you shutdown the server, it's normal to get an error because the browser try to refresh a page from a server that isn't online

Show
Emmanuel Venisse added a comment - I don't understand. When I force a build on the project group page, and wait a long time, a new build isn't built a new time by the meta-refresh because we are on the projectGroupSummary.action and not the buildProject.action due to redirect, so it seems to be fixed. Do I miss something? If you shutdown the server, it's normal to get an error because the browser try to refresh a page from a server that isn't online
Hide
Permalink
Olivier Lamy added a comment -

Concerning server online you're right (my bad).
I have just try it (force a build before lunch time).
Build number was 26 at the end of lunch time build number was 46 (I know long lunch time but I'm a french guy ).
How do you force the build with the submit button or with the link in a project ?
For me it happend only with the link.
Sorry no irc access now, we can discuss this evening.

Show
Olivier Lamy added a comment - Concerning server online you're right (my bad). I have just try it (force a build before lunch time). Build number was 26 at the end of lunch time build number was 46 (I know long lunch time but I'm a french guy ). How do you force the build with the submit button or with the link in a project ? For me it happend only with the link. Sorry no irc access now, we can discuss this evening.
Hide
Permalink
Emmanuel Venisse added a comment -

haha, I tried with the submit button. I'll try with the link. Thanks for this informations

Show
Emmanuel Venisse added a comment - haha, I tried with the submit button. I'll try with the link. Thanks for this informations
Hide
Permalink
Emmanuel Venisse added a comment -

Fixed.

Show
Emmanuel Venisse added a comment - Fixed.

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    Olivier Lamy
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: