Editing a Project Group's name to an empty string generates an exception

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Web interface
  • Labels:
    None
  • Complexity:
    Intermediate

Description

To replicate (assuming the user has sufficient roles):

1. Create a project group (name="asdf", id="asdf")
2. Edit a project group, change name into ""

Result:
Caused by: org.codehaus.plexus.rbac.profile.RoleProfileException: invalid role
at org.codehaus.plexus.rbac.profile.AbstractDynamicRoleProfile.renameRole(AbstractDynamicRoleProfile.java:405)
at org.codehaus.plexus.rbac.profile.DefaultRoleProfileManager.renameDynamicRole(DefaultRoleProfileManager.java:134)
at org.apache.maven.continuum.web.action.ProjectGroupAction.save(ProjectGroupAction.java:262)
... 78 more
Caused by: org.codehaus.plexus.security.rbac.RbacObjectInvalidException: Resource.identifier must not be empty.
at org.codehaus.plexus.security.rbac.RBACObjectAssertions.assertValid(RBACObjectAssertions.java:123)
at org.codehaus.plexus.security.rbac.RBACObjectAssertions.assertValid(RBACObjectAssertions.java:110)
at org.codehaus.plexus.security.authorization.rbac.store.jdo.JdoRbacManager.saveResource(JdoRbacManager.java:458)
at org.codehaus.plexus.security.authorization.rbac.store.cached.CachedRbacManager.saveResource(CachedRbacManager.java:662)
at org.codehaus.plexus.rbac.profile.AbstractDynamicRoleProfile.renameRole(AbstractDynamicRoleProfile.java:381)
... 80 more

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CONTINUUM-1290 Project ID is not validated when adding a Project Group

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nap Ramirez added a comment -

Attached patch contains a quick fix for validating the empty string.

Show
Nap Ramirez added a comment - Attached patch contains a quick fix for validating the empty string.
Hide
Permalink
Nap Ramirez added a comment -

I forgot to paste the main exception, here it is:

org.apache.maven.continuum.ContinuumException: unable to rename the project group
at org.apache.maven.continuum.web.action.ProjectGroupAction.save(ProjectGroupAction.java:270)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)

Show
Nap Ramirez added a comment - I forgot to paste the main exception, here it is: org.apache.maven.continuum.ContinuumException: unable to rename the project group at org.apache.maven.continuum.web.action.ProjectGroupAction.save(ProjectGroupAction.java:270) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585)
Hide
Permalink
Maria Odea Ching added a comment -

Applied patch -r536738. Thanks!

Show
Maria Odea Ching added a comment - Applied patch -r536738. Thanks!

People

  • Assignee:
    Maria Odea Ching
    Reporter:
    Nap Ramirez
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: