Continuum
  1. Continuum
  2. CONTINUUM-1098

Cannot upload a Maven 2 Project with modules

    Details

    • Complexity:
      Intermediate
    • Number of attachments :
      4
    1. CONTINUUM-1098-continuum-webapp.patch
      5 kB
      Franz Allan Valencia See
    2. CONTINUUM-1098-continuum-webapp-2.patch
      4 kB
      Franz Allan Valencia See
    3. error logs.txt
      84 kB
      Franz Allan Valencia See
    1. error page.JPG
      73 kB

      Issue Links

        Activity

        Hide
        Carlos Sanchez added a comment -

        using upload pom, right? that never worked and can't work as the file is uploaded to the server where the modules poms are not available

        Show
        Carlos Sanchez added a comment - using upload pom, right? that never worked and can't work as the file is uploaded to the server where the modules poms are not available
        Hide
        Franz Allan Valencia See added a comment -

        Carlos,

        Yes, it is via upload pom. It doesn't seem to have any problems with POM Url.

        Do you have any suggestion how to fix this? Right now I can think of only two approaches:

        a. Ask the user to upload every pom.xml, and
        b. Read the scm of the uploaded pom.xml, and use that as the base directory for the modules.

        With approach a, it is a pretty safe approach, but very tiresome for the user if it involves several modules, and might be impratical for a really huge project.
        And for approach b, we may need to ask for credentials as well ( I don't think requiring an scm url would be much of an issue, since currently, continuum does require the poms to have an scm url ).

        Cheers,
        Franz

        Show
        Franz Allan Valencia See added a comment - Carlos, Yes, it is via upload pom. It doesn't seem to have any problems with POM Url. Do you have any suggestion how to fix this? Right now I can think of only two approaches: a. Ask the user to upload every pom.xml, and b. Read the scm of the uploaded pom.xml, and use that as the base directory for the modules. With approach a, it is a pretty safe approach, but very tiresome for the user if it involves several modules, and might be impratical for a really huge project. And for approach b, we may need to ask for credentials as well ( I don't think requiring an scm url would be much of an issue, since currently, continuum does require the poms to have an scm url ). Cheers, Franz
        Hide
        Emmanuel Venisse added a comment -

        It isn't possible actually. This feature need some design before implementation.

        Approach b seems to be the best but we need to implement the possibility to look at modules list and see if sub-modules are already in continuum. With this, all new modules will can be added in continuum automatically.

        Show
        Emmanuel Venisse added a comment - It isn't possible actually. This feature need some design before implementation. Approach b seems to be the best but we need to implement the possibility to look at modules list and see if sub-modules are already in continuum. With this, all new modules will can be added in continuum automatically.
        Hide
        Franz Allan Valencia See added a comment -

        Good day to you, Emmanuel,

        I see.

        So I guess this no-duplice-project rule applies not only to the uploading of m2 project (with submodules) but to other tasks as well ( such as manually adding a project that already exists, moving to a group where that project already exists, etc). Did I get that right?

        Also, will this rule will apply to m1, ant, and shell project as well?

        And what would be the definition of a project duplicate? For M2, would it be if two projects have the same artifact key and belong to the same project group? Or will we included packaging? ..And what about for the other project types?

        Maybe this deserves an issue of its own If so, maybe this issue can progress on its own and we'll just add the no-duplicate-project mechanism later on when its finish.

        WDYT?

        Cheers,
        Franz

        Show
        Franz Allan Valencia See added a comment - Good day to you, Emmanuel, I see. So I guess this no-duplice-project rule applies not only to the uploading of m2 project (with submodules) but to other tasks as well ( such as manually adding a project that already exists, moving to a group where that project already exists, etc). Did I get that right? Also, will this rule will apply to m1, ant, and shell project as well? And what would be the definition of a project duplicate? For M2, would it be if two projects have the same artifact key and belong to the same project group? Or will we included packaging? ..And what about for the other project types? Maybe this deserves an issue of its own If so, maybe this issue can progress on its own and we'll just add the no-duplicate-project mechanism later on when its finish. WDYT? Cheers, Franz
        Hide
        Franz Allan Valencia See added a comment -

        CONTINUUM-1098-continuum-webapp.patch contains a workaround to this problem by allowing file:/<file path> to the POM Url, as well as an improve error message when uploading an m2 project with modules.

        Show
        Franz Allan Valencia See added a comment - CONTINUUM-1098 -continuum-webapp.patch contains a workaround to this problem by allowing file:/ <file path> to the POM Url, as well as an improve error message when uploading an m2 project with modules.
        Hide
        Franz Allan Valencia See added a comment -

        CONTINUUM-1098-continuum-webapp-2.patch just has an error message ( since the workaround does not work ).

        Show
        Franz Allan Valencia See added a comment - CONTINUUM-1098 -continuum-webapp-2.patch just has an error message ( since the workaround does not work ).
        Hide
        Emmanuel Venisse added a comment -

        Applied.

        Show
        Emmanuel Venisse added a comment - Applied.

          People

          • Assignee:
            Emmanuel Venisse
            Reporter:
            Franz Allan Valencia See
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: