Support java.util.Map

Details

Type: Bug
Status: Reopened
Priority: Major
Resolution: Unresolved
Affects Version/s: 0.9.5.3
Fix Version/s: None
Component/s: XML
Labels:
None
Environment:
Operating System: Windows 2000
Platform: PC

Bugzilla Id:
1740
Number of attachments :
1

Description

I tried a little and implemented it. I will attach the java file

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

MapClassDescriptor.java

14/Sep/04 6:47 AM

10 kB

Michael Kopp

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Michael Kopp added a comment - 14/Sep/04 6:47 AM

Created an attachment (id=659)
Map Descriptor

Show

Michael Kopp added a comment - 14/Sep/04 6:47 AM Created an attachment (id=659) Map Descriptor

Hide

Permalink

Michael Kopp added a comment - 14/Sep/04 6:47 AM - edited

I tried it with the following piece of code in a Junit test:


    public void testMap() throws ValidationException, MarshalException, IOException
    {
        Map lMap = new HashMap();
        lMap.put("PATH","tmp");
        final StringWriter lStringWriter = new StringWriter();
        final Marshaller lMarshaller = new Marshaller(lStringWriter);
        final ClassDescriptorResolverImpl lCdr = new ClassDescriptorResolverImpl();
        final MapClassDescriptor lClassDesc = new MapClassDescriptor();
        lCdr.associate(java.util.Map.class,  lClassDesc);
        lCdr.associate(java.util.HashMap.class,  lClassDesc);
        lCdr.associate(java.util.Hashtable.class,  lClassDesc);
        lMarshaller.setResolver(lCdr);

        lMarshaller.marshal(lMap);
        logger.info(lStringWriter.toString());

        Unmarshaller um = new Unmarshaller(java.util.Map.class);

        um.setResolver(lCdr);
        lMap = (Map) um.unmarshal(new StringReader(lStringWriter.toString()));

        logger.info("" + lMap);

    }

Show

Michael Kopp added a comment - 14/Sep/04 6:47 AM - edited I tried it with the following piece of code in a Junit test: public void testMap() throws ValidationException, MarshalException, IOException { Map lMap = new HashMap(); lMap.put( "PATH" , "tmp" ); final StringWriter lStringWriter = new StringWriter(); final Marshaller lMarshaller = new Marshaller(lStringWriter); final ClassDescriptorResolverImpl lCdr = new ClassDescriptorResolverImpl(); final MapClassDescriptor lClassDesc = new MapClassDescriptor(); lCdr.associate(java.util.Map.class, lClassDesc); lCdr.associate(java.util.HashMap.class, lClassDesc); lCdr.associate(java.util.Hashtable.class, lClassDesc); lMarshaller.setResolver(lCdr); lMarshaller.marshal(lMap); logger.info(lStringWriter.toString()); Unmarshaller um = new Unmarshaller(java.util.Map.class); um.setResolver(lCdr); lMap = (Map) um.unmarshal( new StringReader(lStringWriter.toString())); logger.info("" + lMap); }

Hide

Permalink

Keith Visco added a comment - 14/Sep/04 11:17 AM

Michael, I appreciate the contribution, but java.util.Map works just fine
in Castor, it already has a special MapItem class and a built-in handler for
dealing with java.util.Map.

Show

Keith Visco added a comment - 14/Sep/04 11:17 AM Michael, I appreciate the contribution, but java.util.Map works just fine in Castor, it already has a special MapItem class and a built-in handler for dealing with java.util.Map.

Hide

Permalink

Keith Visco added a comment - 14/Sep/04 11:22 AM - edited

Here is an example of maps:

ftp://ftp.exolab.org/pub/castor/examples/CastorXML/HashMaps/example1.zip

Castor also supports nested <class> mappings inside the bind-xml element for
greater control of how to map a Map.

For example, you can replace the mapping.xml inside the example1.zip with
something like:

<mapping>
      <class name="Root">
          <field name="children"  type="org.exolab.castor.mapping.MapItem" collection="hashtable"
              get-method="getChildren"
              set-method="setChildren">
              <bind-xml>
                  <class name="org.exolab.castor.mapping.MapItem">
                     <field name="key" type="string">
                         <bind-xml name="item.key" node="element"/>
                     </field>
                     <field name="value" type="string">
                         <bind-xml name="item.value" node="element"/>
                     </field>
                  </class>
              </bind-xml>
          </field>
      </class>
</mapping>

I'm marking as WORKSFORME since I can already using java.util.Map in my Castor
applications today.

Show

Keith Visco added a comment - 14/Sep/04 11:22 AM - edited Here is an example of maps: ftp://ftp.exolab.org/pub/castor/examples/CastorXML/HashMaps/example1.zip Castor also supports nested <class> mappings inside the bind-xml element for greater control of how to map a Map. For example, you can replace the mapping.xml inside the example1.zip with something like: <mapping> <class name= "Root" > <field name= "children" type= "org.exolab.castor.mapping.MapItem" collection= "hashtable" get-method= "getChildren" set-method= "setChildren" > <bind-xml> <class name= "org.exolab.castor.mapping.MapItem" > <field name= "key" type= "string" > <bind-xml name= "item.key" node= "element" /> </field> <field name= "value" type= "string" > <bind-xml name= "item.value" node= "element" /> </field> </class> </bind-xml> </field> </class> </mapping> I'm marking as WORKSFORME since I can already using java.util.Map in my Castor applications today.

Hide

Permalink

Keith Visco added a comment - 14/Sep/04 11:24 AM

One a related note, there is a lot of stuff in Castor that isn't yet supported,
we could certainly use your help in other areas!

Show

Keith Visco added a comment - 14/Sep/04 11:24 AM One a related note, there is a lot of stuff in Castor that isn't yet supported, we could certainly use your help in other areas!

Hide

Permalink

Michael Kopp added a comment - 15/Sep/04 1:19 AM - edited

I saw that you have some support but it doesn't really work. can we discuss
about enhanceing it?

1. Map as root type:
The following code does not work:

  Map lMap = new HashMap();
  lMap.put("PATH","tmp");
  final StringWriter lStringWriter = new StringWriter();
  Marshaller.marshal(lMap,lStringWriter);
  final String s = lStringWriter.toString();

The result is:

  <hash-map empty="false" empty="false"/>

2. Map as part of another object does work, but
2a. the resulting xml does not short any difference between HashMap and Hashtable

Your impl:

<m><m xsi:type="java:org.exolab.castor.mapping.MapItem"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"><key
xsi:type="java:java.lang.String">PATH</key><value
xsi:type="java:java.lang.String">tmp</value></m></m>

My impl:

 <m><m xsi:type="java:java.util.HashMap"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"><entry><key
xsi:type="java:java.lang.String">PATH</key><value
xsi:type="java:java.lang.String">tmp</value></entry></m></m>

2b. the xsi type refers to an internal castor type which is not very nice.

The class descriptor implementation works on your framework and does not need
the special handling you did in the main code, which IMO is normally better

And the result looks very much like your result.

It would be great if you could reconsider your decission.

Show

Michael Kopp added a comment - 15/Sep/04 1:19 AM - edited I saw that you have some support but it doesn't really work. can we discuss about enhanceing it? 1. Map as root type: The following code does not work: Map lMap = new HashMap(); lMap.put( "PATH" , "tmp" ); final StringWriter lStringWriter = new StringWriter(); Marshaller.marshal(lMap,lStringWriter); final String s = lStringWriter.toString(); The result is: <hash-map empty= " false " empty= " false " /> 2. Map as part of another object does work, but 2a. the resulting xml does not short any difference between HashMap and Hashtable Your impl: <m><m xsi:type= "java:org.exolab.castor.mapping.MapItem" xmlns:xsi= "http: //www.w3.org/2001/XMLSchema-instance" ><key xsi:type= "java:java.lang. String " >PATH</key><value xsi:type= "java:java.lang. String " >tmp</value></m></m> My impl: <m><m xsi:type= "java:java.util.HashMap" xmlns:xsi= "http: //www.w3.org/2001/XMLSchema-instance" ><entry><key xsi:type= "java:java.lang. String " >PATH</key><value xsi:type= "java:java.lang. String " >tmp</value></entry></m></m> 2b. the xsi type refers to an internal castor type which is not very nice. The class descriptor implementation works on your framework and does not need the special handling you did in the main code, which IMO is normally better And the result looks very much like your result. It would be great if you could reconsider your decission.

Hide

Permalink

Werner Guttmann added a comment - 20/Apr/11 7:54 AM

I can confirm that point 1. still produces the following wrong XML:

<?xml version="1.0" encoding="UTF-8"?>
<hash-map empty="false"/>

Having said that, I'd rather close this issue and open one or more new ones that have a more narrow subject.

Show

Werner Guttmann added a comment - 20/Apr/11 7:54 AM I can confirm that point 1. still produces the following wrong XML: <?xml version= "1.0" encoding= "UTF-8" ?> <hash-map empty= " false " /> Having said that, I'd rather close this issue and open one or more new ones that have a more narrow subject.

People

Assignee:

Unassigned

Reporter:

Michael Kopp

Vote (1)

Watch (1)

Dates

Created:

14/Sep/04 6:46 AM

Updated:

20/Apr/11 7:54 AM