castor

SourceGenerator ignores "final" attribute on <java-class/> in binding file.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.5.3
  • Fix Version/s: 1.0.2
  • Component/s: XML code generator
  • Labels:
    None
  • Environment:
    Operating System: Windows 2000
    Platform: PC
  • Bugzilla Id:
    1579
  • Number of attachments :
    3

Description

SourceGenerator ignores "final" attribute on <java-class/> in binding file.

Test case details:
1) SourceGenerator command: java cp .;castor-0.9.5.3.jar;castor-0.9.5.3
xml.jar;xml-apis.jar;xercesImpl.jar org.exolab.castor.builder.SourceGenerator -
i "castor-bug.xsd" -types j2 -nomarshall -binding-file castor-bug-binding.xml

Attachments to be added:
-Example schema
-Example binding file.

  1. XML File
    castor-bug-1579.xsd
    30/Mar/04 10:22 AM
    0.4 kB
    derek.sayeau
  2. XML File
    castor-bug-1579-binding.xml
    30/Mar/04 10:22 AM
    0.7 kB
    derek.sayeau
  3. Text File
    patch.c721.20060726.txt
    26/Jul/06 8:43 AM
    3 kB
    Werner Guttmann

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
derek.sayeau added a comment -

Created an attachment (id=429)
Example binding file.

Show
derek.sayeau added a comment - Created an attachment (id=429) Example binding file.
Hide
Permalink
derek.sayeau added a comment -

Created an attachment (id=430)
Example schema.

Show
derek.sayeau added a comment - Created an attachment (id=430) Example schema.
Hide
Permalink
Keith Visco added a comment -

Arnaud can you look into this?

Show
Keith Visco added a comment - Arnaud can you look into this?
Hide
Permalink
Thomas Zooman added a comment -

the problem is in JClass.java

JModifiers modifiers = getModifiers();
if (modifiers.isPrivate())

{ buffer.append("private "); }

else if (modifiers.isPublic())

{ buffer.append("public "); }

if (modifiers.isAbstract())

{ buffer.append("abstract "); }

append final and static are missing.

if ( modifiers.isFinal() && modifiers.isAbstract() == false )
{
buff.append("final ");
}

Show
Thomas Zooman added a comment - the problem is in JClass.java JModifiers modifiers = getModifiers(); if (modifiers.isPrivate()) { buffer.append("private "); } else if (modifiers.isPublic()) { buffer.append("public "); } if (modifiers.isAbstract()) { buffer.append("abstract "); } append final and static are missing. if ( modifiers.isFinal() && modifiers.isAbstract() == false ) { buff.append("final "); }
Hide
Permalink
Thomas Zooman added a comment -

sorry, static is not allow in outter class

Show
Thomas Zooman added a comment - sorry, static is not allow in outter class

People

  • Assignee:
    Werner Guttmann
    Reporter:
    derek.sayeau
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: