Marshaller adds Java namespace regardless of one being passed via the setNamespaceMapping method

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3.2
  • Fix Version/s: 1.3.3rc1
  • Component/s: XML
  • Labels:
    None

Description

This is related to issue 2231. We added our own namespace called temp-java-xsd for the java prefix because Castor did not do this before 1.3.2.

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. CASTOR-2231 No namespace defined by castor for the automatically generated one "java:" on xsi:type attributes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

I'd appreciate any sample documents that show how things look at your side.

Show
Werner Guttmann added a comment - I'd appreciate any sample documents that show how things look at your side.
Hide
Permalink
Werner Guttmann added a comment - - edited

Without really knowing what you are trying to achieve, here's a patch for what I believe the problem could be.

Index: xml/src/main/java/org/exolab/castor/xml/Marshaller.java
===================================================================
--- xml/src/main/java/org/exolab/castor/xml/Marshaller.java	(revision 9081)
+++ xml/src/main/java/org/exolab/castor/xml/Marshaller.java	(working copy)
@@ -1626,8 +1626,10 @@
             //-- save type information
             atts.addAttribute(XSI_NAMESPACE, TYPE_ATTR, XSI_TYPE, CDATA, typeName);
             if (useJavaPrefix) {
-                //-- declare Java namespace, if necessary
-                declareNamespace("java", "http://java.sun.com");
+               if (_namespaces.getNamespaceURI("java") == null) {
+                  //-- declare Java namespace, if necessary
+                  declareNamespace("java", "http://java.sun.com");
+               }
             }
         }
Show
Werner Guttmann added a comment - - edited Without really knowing what you are trying to achieve, here's a patch for what I believe the problem could be. 
Index: xml/src/main/java/org/exolab/castor/xml/Marshaller.java
===================================================================
--- xml/src/main/java/org/exolab/castor/xml/Marshaller.java	(revision 9081)
+++ xml/src/main/java/org/exolab/castor/xml/Marshaller.java	(working copy)
@@ -1626,8 +1626,10 @@
             //-- save type information
             atts.addAttribute(XSI_NAMESPACE, TYPE_ATTR, XSI_TYPE, CDATA, typeName);
             if (useJavaPrefix) {
-                //-- declare Java namespace, if necessary
-                declareNamespace("java", "http://java.sun.com");
+               if (_namespaces.getNamespaceURI("java") == null) {
+                  //-- declare Java namespace, if necessary
+                  declareNamespace("java", "http://java.sun.com");
+               }
             }
         }
Hide
Permalink
Hein Stolle added a comment -

I have attached a test project to demonstrate that validation fails when there are two different java: namespaces declared in one XML document.

Show
Hein Stolle added a comment - I have attached a test project to demonstrate that validation fails when there are two different java: namespaces declared in one XML document.
Hide
Permalink
Werner Guttmann added a comment -

Hein, have you been able to put above patch at some use ?

Show
Werner Guttmann added a comment - Hein, have you been able to put above patch at some use ?
Hide
Permalink
Hein Stolle added a comment -

Certainly, it solved our problem. Is it possible to include it in the next release?

Show
Hein Stolle added a comment - Certainly, it solved our problem. Is it possible to include it in the next release?
Hide
Permalink
Werner Guttmann added a comment -

yes, it will be shipped as part of 1.3.3.

Show
Werner Guttmann added a comment - yes, it will be shipped as part of 1.3.3.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Hein Stolle
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: