castor

SQLRelationLoader: Use ColumnInfo classes to bind parameter

Details

  • Type: Sub-task Sub-task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3.2
  • Fix Version/s: 1.3.3rc1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    9

Description

Use ColumnInfo classes to bind parameters in SQLRelationLoader.

  1. Text File
    patch-20110527.txt
    27/May/11 11:29 AM
    15 kB
    Johannes Venzke
  2. Text File
    patch-C3096-20110607-createRelationResolver.txt
    07/Jun/11 11:33 AM
    18 kB
    Ralf Joachim
  3. Text File
    patch-C3096-20110615.txt
    15/Jun/11 5:47 PM
    55 kB
    Ralf Joachim
  4. Text File
    patch-SQLRelationLoader-ColumnInfo-110530.txt
    30/May/11 3:06 PM
    19 kB
    Johannes Venzke
  5. Text File
    patch-SQLRelationLoader-ColumnInfo-110531.txt
    31/May/11 6:47 AM
    24 kB
    Johannes Venzke
  6. Text File
    patch-SQLRelationLoader-ColumnInfo-110601.txt
    01/Jun/11 3:08 PM
    26 kB
    Johannes Venzke
  7. Text File
    patch-SQLRelationLoader-ColumnInfo-110603.txt
    03/Jun/11 2:11 PM
    29 kB
    Johannes Venzke
  8. Text File
    patch-SQLRelationLoader-ColumnInfo-110606.txt
    06/Jun/11 3:21 PM
    29 kB
    Johannes Venzke
  9. Text File
    patch-SQLRelationLoader-ColumnInfo-110610-final.txt
    10/Jun/11 7:55 AM
    39 kB
    Johannes Venzke

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Johannes Venzke added a comment -

This patch reflects my current state of development.
It can be committed alread, but it isn't meant to be finished.

Show
Johannes Venzke added a comment - This patch reflects my current state of development. It can be committed alread, but it isn't meant to be finished.
Hide
Permalink
Johannes Venzke added a comment -

Cleaned up code a little bit in SQLRelationLoader. Moved passing of convertors from SQLEngine to InfoFactory (I think it's better to commit patch 3100 first).
There is still potential to improve things: for example can the map with parameter names be created and kept globally. Also should SQLRelationLoader not instantiate ColumnValues by itself, but should call a method of TableInfo.

Show
Johannes Venzke added a comment - Cleaned up code a little bit in SQLRelationLoader. Moved passing of convertors from SQLEngine to InfoFactory (I think it's better to commit patch 3100 first). There is still potential to improve things: for example can the map with parameter names be created and kept globally. Also should SQLRelationLoader not instantiate ColumnValues by itself, but should call a method of TableInfo.
Hide
Permalink
Johannes Venzke added a comment -

Version of further development. What I wrote to last patch applies here too.

Show
Johannes Venzke added a comment - Version of further development. What I wrote to last patch applies here too.
Hide
Permalink
Johannes Venzke added a comment -

Still unfinished, but better than before.
Commit change in InfoFactory first (see above)

Show
Johannes Venzke added a comment - Still unfinished, but better than before. Commit change in InfoFactory first (see above)
Hide
Permalink
Johannes Venzke added a comment -

Recreated patch because of svn changes.
Everything works, but it's not finished.

Show
Johannes Venzke added a comment - Recreated patch because of svn changes. Everything works, but it's not finished.
Hide
Permalink
Johannes Venzke added a comment -

Recreated patch for current SVN state and advanced it.

Show
Johannes Venzke added a comment - Recreated patch for current SVN state and advanced it.
Hide
Permalink
Ralf Joachim added a comment -

Patch that shows how SQLRelationResolver should be created in SQLEngine.createSQLRelationResolver().
I've check debug output of cpactf run which showed that all informations of RelationTableInfo are correct.

Show
Ralf Joachim added a comment - Patch that shows how SQLRelationResolver should be created in SQLEngine.createSQLRelationResolver(). I've check debug output of cpactf run which showed that all informations of RelationTableInfo are correct.
Hide
Permalink
Johannes Venzke added a comment -

Everything is done and works now. This seems to be the final patch.
One thing one could do is to let Identity implement Iterable which would make the code more elegant. But this would be a new issue.

Show
Johannes Venzke added a comment - Everything is done and works now. This seems to be the final patch. One thing one could do is to let Identity implement Iterable which would make the code more elegant. But this would be a new issue.
Hide
Permalink
Johannes Venzke added a comment -

Date pf patch file was wrong.

Show
Johannes Venzke added a comment - Date pf patch file was wrong.
Hide
Permalink
Ralf Joachim added a comment -

Final patch with some minor modifications to the one from Johannes.

Show
Ralf Joachim added a comment - Final patch with some minor modifications to the one from Johannes.

People

  • Assignee:
    Johannes Venzke
    Reporter:
    Johannes Venzke
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: