castor

Move LockEngine.TypeInfo from an inner to a normal class

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3.2
  • Fix Version/s: 1.3.3rc1
  • Component/s: JDO
  • Labels:
    None
  • Number of attachments :
    1

Description

LockEngine takes too much responsibility, some functions should be separated. The TypeInfo class have some responsibility of cache handling and locking. In order to reduce the complexity of LockEngine, the TypeInfo should be moved out.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment - - edited

Yes, very much in favour of this. As a first step, can I ask you to come up with a UML diagram that depicts the current state as well as your intentions ?

Show
Werner Guttmann added a comment - - edited Yes, very much in favour of this. As a first step, can I ask you to come up with a UML diagram that depicts the current state as well as your intentions ?
Hide
Permalink
Ralf Joachim added a comment - - edited

A patch is already attached to castor-3065. I only asked Wensheng to seperate the 2 changes. As this is a very small patch we do not need a UML diagram for this but Wnesheng will create them for other changes we have to do.

Show
Ralf Joachim added a comment - - edited A patch is already attached to castor-3065. I only asked Wensheng to seperate the 2 changes. As this is a very small patch we do not need a UML diagram for this but Wnesheng will create them for other changes we have to do.
Hide
Permalink
Werner Guttmann added a comment -

Okay, didn't notice that.

Show
Werner Guttmann added a comment - Okay, didn't notice that.
Hide
Permalink
Ralf Joachim added a comment -

Wensheng, can you please attach a new patch for this after castor-3065 have been committed?

Show
Ralf Joachim added a comment - Wensheng, can you please attach a new patch for this after castor-3065 have been committed?
Hide
Permalink
Wensheng Dou added a comment -

Hi Ralf,
The patch is a little later.
What have been done in the patch?
(1) Move LockEngine.TypeInfo into a normal class
(2) Make some methods public in TypeInfo
(3) Add a method getClassMolder() in TypeInfo
(4) Modify the typeinfo._molder in LockEngine to typeinfo._getClassMolder()

Best regards
Wensheng Dou

Show
Wensheng Dou added a comment - Hi Ralf, The patch is a little later. What have been done in the patch? (1) Move LockEngine.TypeInfo into a normal class (2) Make some methods public in TypeInfo (3) Add a method getClassMolder() in TypeInfo (4) Modify the typeinfo._molder in LockEngine to typeinfo._getClassMolder() Best regards Wensheng Dou
Hide
Permalink
Ralf Joachim added a comment -

Patch committed after adding license and release notes.

Show
Ralf Joachim added a comment - Patch committed after adding license and release notes.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Wensheng Dou
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: