castor

Simplify Method signature of ClonableFieldHandler

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3.2
  • Fix Version/s: 1.3.3rc1
  • Component/s: XML
  • Labels:
    None
  • Source ID:
    2963
  • Number of attachments :
    1

Description

As per issue: 2963, we should simplify the ClonableFieldHandler such that it's copyInstance(FieldHandler) method does not require a FieldHandler parameter (this method is an instance method, and thus we are always passing "this" to the method anyway.

  1. Text File
    c3058.patch
    19/Apr/12 2:54 AM
    6 kB
    Werner Guttmann

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

I am going to rename this new method again (copyFieldHandler()) and move it to a new marker interface.

Show
Werner Guttmann added a comment - I am going to rename this new method again (copyFieldHandler()) and move it to a new marker interface.
Hide
Permalink
Werner Guttmann added a comment -

Final patch for review. Please note that ...

  • I renamed copyInstance() to copyFieldHandler(9 to avoid naming 'collisions' with the other FieldHandler methods.
  • I deprecated the ClonableFieldHandler interface in favour of a new ClonableFieldHandlerMarker interface.
Show
Werner Guttmann added a comment - Final patch for review. Please note that ... I renamed copyInstance() to copyFieldHandler(9 to avoid naming 'collisions' with the other FieldHandler methods. I deprecated the ClonableFieldHandler interface in favour of a new ClonableFieldHandlerMarker interface.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Craig Tataryn
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: