castor
  1. castor
  2. CASTOR-3058

Simplify Method signature of ClonableFieldHandler

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.2
    • Fix Version/s: 1.3.3rc1
    • Component/s: XML
    • Labels:
      None
    • Source ID:
      2963
    • Number of attachments :
      1

      Description

      As per issue: 2963, we should simplify the ClonableFieldHandler such that it's copyInstance(FieldHandler) method does not require a FieldHandler parameter (this method is an instance method, and thus we are always passing "this" to the method anyway.

      1. c3058.patch
        6 kB
        Werner Guttmann

        Activity

        Hide
        Werner Guttmann added a comment -

        I am going to rename this new method again (copyFieldHandler()) and move it to a new marker interface.

        Show
        Werner Guttmann added a comment - I am going to rename this new method again (copyFieldHandler()) and move it to a new marker interface.
        Hide
        Werner Guttmann added a comment -

        Final patch for review. Please note that ...

        • I renamed copyInstance() to copyFieldHandler(9 to avoid naming 'collisions' with the other FieldHandler methods.
        • I deprecated the ClonableFieldHandler interface in favour of a new ClonableFieldHandlerMarker interface.
        Show
        Werner Guttmann added a comment - Final patch for review. Please note that ... I renamed copyInstance() to copyFieldHandler(9 to avoid naming 'collisions' with the other FieldHandler methods. I deprecated the ClonableFieldHandler interface in favour of a new ClonableFieldHandlerMarker interface.

          People

          • Assignee:
            Werner Guttmann
            Reporter:
            Craig Tataryn
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: