castor

Extended org.castor.core.StringUtil to support some operations on Strings which are used very often by UnmarshalHandler

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

equals(String str1, String str2)
isEmpty(String str)
isNotEmpty(String str)
defaultString(String str)

All of those methods take a string that can be null.
Due to this methods it's possible to get rid of many if statements in UnmarshalHandler.

Issue Links

is depended upon by

Sub-task - The sub-task of the issue CASTOR-2971 Introduce a new PrimitiveObjectFactory

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Philipp Erlacher added a comment -

Currently error messages are often produced as String err = "foobar"; err += "foobar"; and so on...
This patch replaced those instantiations with a StringBuffer.

Show
Philipp Erlacher added a comment - Currently error messages are often produced as String err = "foobar"; err += "foobar"; and so on... This patch replaced those instantiations with a StringBuffer.
Hide
Permalink
Philipp Erlacher added a comment -

Sometimes StringBuffers get reused. Like

StringBuffer buffer = null;
while(something)

{ if(buffer==null) buffer = new StringBuffer(); else buffer.setLength(0); someOperations(buffer); }

I extracted this behavior to an own method called resetStringBuffer(StringBuffer buffer).

Show
Philipp Erlacher added a comment - Sometimes StringBuffers get reused. Like StringBuffer buffer = null; while(something) { if(buffer==null) buffer = new StringBuffer(); else buffer.setLength(0); someOperations(buffer); } I extracted this behavior to an own method called resetStringBuffer(StringBuffer buffer).
Hide
Permalink
Werner Guttmann added a comment -

I am fine with the refactorings introduced. Having said that, though, let me just add that all those error messages (irrespective of whether StringBuffer is used or not) should go to resource bundles, and disappear from the source code completely. But this can be done as part of a separate refactoring.

Show
Werner Guttmann added a comment - I am fine with the refactorings introduced. Having said that, though, let me just add that all those error messages (irrespective of whether StringBuffer is used or not) should go to resource bundles, and disappear from the source code completely. But this can be done as part of a separate refactoring.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Philipp Erlacher
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: