castor

"list is not a valid FieldMappingCollectionType" when using MappingTool to create mapping for object with List property

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.3
  • Fix Version/s: None
  • Component/s: XML
  • Labels:
    None
  • Number of attachments :
    1

Description

Trying to create a simple mapping file using MappingTool.write results in

Caused by: java.lang.IllegalArgumentException: list is not a valid FieldMappingCollectionType
at org.exolab.castor.mapping.xml.types.FieldMappingCollectionType.valueOf(FieldMappingCollectionType.java:248)
at org.exolab.castor.tools.MappingTool.addClass(MappingTool.java:390)
at fi.ains.jp.model.service.PersistenceService.autoGenerateMappingFile(PersistenceService.java:173)
at fi.ains.jp.model.service.PersistenceService.saveModel(PersistenceService.java:149)
at fi.ains.jp.controller.applicationModel.JPApplicationModel.saveModel(JPApplicationModel.java:93)
at fi.ains.jp.view.JPApplicationMainView.save(JPApplicationMainView.java:186)
... 34 more

Tried to map simple example:

public class Owner {
private String name;
private List<Vehicle> vehicles = new ArrayList<Vehicle>();

public String getName()

{ return name; }

public void setName(String name) { this.name = name; }

public List<Vehicle> getVehicles() { return (ArrayList<Vehicle>) vehicles; }

public void setVehicles(List<Vehicle> vehicles) { this.vehicles = vehicles; }
}

public class Vehicle {
private String name;
private Owner owner;

public String getName() { return name; }

public void setName(String name)

{ this.name = name; }

public Owner getOwner()

{ return owner; }

public void setOwner(Owner owner)

{ this.owner = owner; }

}

private void autoGenerateMappingFile() {
FileWriter fw = null;
try

{ MappingTool tool = new MappingTool(); tool.setInternalContext(new BackwardCompatibilityContext()); boolean deep = true; File targetFile = new File("generated-mapping.xml"); log.debug("generating mapping file..."); tool.addClass(Owner.class, deep); fw = new FileWriter(targetFile); tool.write(fw); log.debug("...done generating mapping file: " + targetFile); }

catch (IOException ex)

{ throw new RuntimeException(ex); } catch (MappingException ex) { throw new RuntimeException(ex); }

finally

{ IOUtils.closeQuietly(fw); }

}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Janne Mattila added a comment -

forgot one extraneous cast there,

public List<Vehicle> getVehicles()

{ return (ArrayList<Vehicle>) vehicles; }

should have been

public List<Vehicle> getVehicles()

{ return vehicles; }

but has no effect on the end result

Show
Janne Mattila added a comment - forgot one extraneous cast there, public List<Vehicle> getVehicles() { return (ArrayList<Vehicle>) vehicles; } should have been public List<Vehicle> getVehicles() { return vehicles; } but has no effect on the end result
Hide
Permalink
GOUJON Alexandre added a comment -

I made this patch to add list support to castor.

Your sample code was not compiling as is so I modified it a bit, added include ... Now, it works with castor patched.

Give it a try and tell me if it solves the issue.

Show
GOUJON Alexandre added a comment - I made this patch to add list support to castor. Your sample code was not compiling as is so I modified it a bit, added include ... Now, it works with castor patched. Give it a try and tell me if it solves the issue.
Hide
Permalink
Charles Mowers added a comment -

Non initialized collections as well as non initialized primitive arrays such as:

int[] intArray;
private List<Vehicle> vehicles = null;

will throw a null pointer on your patch @ Line 388 .toUpperCase()
when the time comes for generation.

In our case we have null checks and leave initialization to our persistence mechinism,
I am in the process of initializing our collections, but I still have not run our test suites against this
change.

Show
Charles Mowers added a comment - Non initialized collections as well as non initialized primitive arrays such as: int[] intArray; private List<Vehicle> vehicles = null; will throw a null pointer on your patch @ Line 388 .toUpperCase() when the time comes for generation. In our case we have null checks and leave initialization to our persistence mechinism, I am in the process of initializing our collections, but I still have not run our test suites against this change.
Hide
Permalink
Mario L added a comment -

I'd love to have this working - java.util.List is pretty much everywhere in my project...

Show
Mario L added a comment - I'd love to have this working - java.util.List is pretty much everywhere in my project...
Hide
Permalink
Werner Guttmann added a comment -

Mario, what is actually the problem here. Is your 'I'd love to have this working' about general support for lists, or the issue reported here (related to MappingTool).

Show
Werner Guttmann added a comment - Mario, what is actually the problem here. Is your 'I'd love to have this working' about general support for lists, or the issue reported here (related to MappingTool).
Hide
Permalink
Mario L added a comment - - edited

It's about the problem reported here, why
...or are there other List-related problems I'm not aware of?

Now really, maybe instead of thinking about every possible Java class, the FieldMappingCollectionType could simply return some default when the type is not known... (just a crazy idea). See also CASTOR-3193

Show
Mario L added a comment - - edited It's about the problem reported here, why ...or are there other List-related problems I'm not aware of? Now really, maybe instead of thinking about every possible Java class, the FieldMappingCollectionType could simply return some default when the type is not known... (just a crazy idea). See also CASTOR-3193

People

  • Assignee:
    Unassigned
    Reporter:
    Janne Mattila
Vote (3)
Watch (2)

Dates

  • Created:
    Updated: