castor

Improve SQLStatementInsertCheck to incorporate all the exception handling for executeStatement method of KeyGenerators.

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3.1
  • Component/s: JDO queries
  • Labels:
    None
  • Number of attachments :
    1

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
AHMAD HASSAN added a comment -

Improved the exception handling in the executeStatement method of KeyGenerators. isDuplicateKeyException method has been removed from persistence factory as we are already checking that in SQLStatementInsertCheck class in case of NoKeyGenerator and AbstractBeforeKeyGenerator. Where as in case of SequenceDuringKeyGenerator and AbstractAfterKeyGenerator, we are just throwing the exception because we cannot check for duplicate values in that case.

Regards, Ahmad

Show
AHMAD HASSAN added a comment - Improved the exception handling in the executeStatement method of KeyGenerators. isDuplicateKeyException method has been removed from persistence factory as we are already checking that in SQLStatementInsertCheck class in case of NoKeyGenerator and AbstractBeforeKeyGenerator. Where as in case of SequenceDuringKeyGenerator and AbstractAfterKeyGenerator, we are just throwing the exception because we cannot check for duplicate values in that case. Regards, Ahmad
Hide
Permalink
Ralf Joachim added a comment -

Committed patch almost as is.

Show
Ralf Joachim added a comment - Committed patch almost as is.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.