The patch includes the use of Insert class hierarchy to in Key generators. The insert hierarchy has also been improved to add sequences to insert statement. Because of that, patchSQL method has been removed from the keyGenerator interface.
I don't see any usecase in which patchSQL method would have thrown the MappingException. Because of that I removed the catch block handling in SequenceAfter and SequenceDuring keygenrator when MappingException is thrown by patchSQL method previously.
Additionally I used the added the parameterSize method in the QueryContext class which gives the number of added parameters to sql statement. In SequenceDuringKeyGenerator I used that parameter size instead of count. It would be better if we check this logic against oracle engine.
Regards, Ahmad
Sub-task
Closed
Minor
The patch includes the use of Insert class hierarchy to in Key generators. The insert hierarchy has also been improved to add sequences to insert statement. Because of that, patchSQL method has been removed from the keyGenerator interface.
I don't see any usecase in which patchSQL method would have thrown the MappingException. Because of that I removed the catch block handling in SequenceAfter and SequenceDuring keygenrator when MappingException is thrown by patchSQL method previously.
Additionally I used the added the parameterSize method in the QueryContext class which gives the number of added parameters to sql statement. In SequenceDuringKeyGenerator I used that parameter size instead of count. It would be better if we check this logic against oracle engine.
Regards, Ahmad