castor
  1. castor
  2. CASTOR-2477 Let KeyGenerator taken over role of SQLSatementCreate
  3. CASTOR-2780

Move executeStatementNoKeyGen() method from SQLStatementCreate to NoKeyGenerator

    Details

    • Type: Sub-task Sub-task
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.1
    • Component/s: JDO queries
    • Labels:
      None
    • Number of attachments :
      1

      Activity

      Hide
      AHMAD HASSAN added a comment -

      Moved executeStatement and bindFields method to NoKeyGenerator. To make use of it, I temporarily typecast the _keyGen object in SQLStatementCreate which is quite dirty hack. But this type casting stuff will be removed after declaring executeStatement method in KeyGenerator interface. This will be done after all the executeStatementXYZ methods are shifted to respective key generators.

      Regards, Ahmd

      Show
      AHMAD HASSAN added a comment - Moved executeStatement and bindFields method to NoKeyGenerator. To make use of it, I temporarily typecast the _keyGen object in SQLStatementCreate which is quite dirty hack. But this type casting stuff will be removed after declaring executeStatement method in KeyGenerator interface. This will be done after all the executeStatementXYZ methods are shifted to respective key generators. Regards, Ahmd
      Hide
      AHMAD HASSAN added a comment -

      P.S. ATM statement string is passed as arguments to executeStatement. But this will be removed when buildStatement will be shifted to that class.

      Regards, Ahmad

      Show
      AHMAD HASSAN added a comment - P.S. ATM statement string is passed as arguments to executeStatement. But this will be removed when buildStatement will be shifted to that class. Regards, Ahmad
      Hide
      Ralf Joachim added a comment -

      Patch committed as is.

      Show
      Ralf Joachim added a comment - Patch committed as is.

        People

        • Assignee:
          AHMAD HASSAN
          Reporter:
          Ralf Joachim
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: