Separating Query Construction part from SQLStatementStore into separate Class Hierarchy

The attached patch is for review purposes. Some of the classes overlaps the classes included in the Delete class hierarchy implementation. The delete class hierarchy task is CASTOR-2743. But after the design has been finalized then this overlapping will be removed in the final patch submission.

Just to describe the way of using this class hierarchy, I have added the main method in the Update base class which adds generated the sql using this new class hierarchy. In order to check this, you have to run the Update class as simple java application. The code snippet for using this class hierarchy is shown below

    Update del = new Update (new Table("ahmad"));

        del.addAndCondition("name", CompareOperator.EQ, "where:name");
        del.addAndCondition("id", CompareOperator.EQ, "where:id");

        del.addNullCondition("age");
        
        del.addAssignment("id", "set:id");
        del.addAssignment("age", "set:age");  
        
        System.out.println(del.toString() + "\n\n");
        
        del.bind(null, "where:name", "ahmad hassan");
        del.bind(null, "where:id", "check");
        del.bind(null, "set:id", "checkset");

This way, the whole sql construction code will be moved out of SQLStatementStore. The new class hierarchy will provide that abstraction. This is easy to use and looks more modular and logical.

Best Regards, Hassan

The update hierarchy is almost done. I tried the implementation with both Cloning and New Initialization method. Both works fine but what do you advise to incorporate?

In case of Cloning, the CompoundCondition class has to implement the Cloneable interface and I add the following method

   public Object Clone () throws CloneNotSupportedException  {
        return this;
    }

The way of usage of above two methods is:

         AndCondition base = _update.getCondition();
      
        //Cloning
        _update.setCondition((AndCondition)base.Clone());
    
        //New initialization

       _update.setCondition((AndCondition)new AndCondition().and(base));

Thanks.

I think the implementation of clone method and handling of base is not correct.

The patch includes the following classes.

Update
Assignment
SQLStatementStore
QueryConstants

One thing to note down here is that, I commented some of the LOG messages in SQLStatementStore. If we have to keep this log messages then we have to walk through the Update class hierarchy again and again. Because we are attaching QueryContext object with Update hierarchy after all the Conditions have been attached. So until that step, I have commented log statements. I think there are two of them which I commented.

Regards, Hassan

The updated patch which involves the use of PersistenceFactory for quoting the column names.
The following classes are included.

QueryConstants
Update
AndCondition
Assignment
SQLStatementStore

Best Regards, Ahmad

Final patch.