castor
  1. castor
  2. CASTOR-2671

Add Maven profiles to CPACTF module

    Details

    • Type: Task Task
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3.4
    • Component/s: JDO tests
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Add database-specific Maven profiles to CPACTF module.

      1. patch.c2671.20090315.txt
        15 kB
        Werner Guttmann
      2. patch.c2671.20090315-002.txt
        18 kB
        Werner Guttmann

        Issue Links

          Activity

          Hide
          Werner Guttmann added a comment -

          Initial patch for review. To execute test suite for ...., please issue:

          • Derby: mvn clean install
          • mySQL: mvn -Ddatabase=mysql-drv -P mysql clean install

          Note: I still have to add one more sql-maven-plugin execution to automate database creation.

          Show
          Werner Guttmann added a comment - Initial patch for review. To execute test suite for ...., please issue: Derby: mvn clean install mySQL: mvn -Ddatabase=mysql-drv -P mysql clean install Note: I still have to add one more sql-maven-plugin execution to automate database creation.
          Hide
          Werner Guttmann added a comment -

          Updated patch where I added two more sql-maven-plugin executions to drop and create the database schema required for the test suite to be run.

          Show
          Werner Guttmann added a comment - Updated patch where I added two more sql-maven-plugin executions to drop and create the database schema required for the test suite to be run.
          Hide
          Ralf Joachim added a comment -

          I like the idea of maven profiles that will allow to execute cpactf through maven against different databases. There are only 3 points I do not like much at the current patch which uses maven-sql-plugin to setup database:

          1. You have to add connection information for every database in pom.xml and cpactf-conf.xml. And they have to be in sync to execute tests successfully.

          2. You have to add <srcFile>...</srcFile> definition in pom.xml for every database engine and every test. As we support 11 database engines and have about 85 tests this will lead us to around 1000 such definitions in pom.xml. In my opinon it will be a nightmare to maintain them. Not to forget the length of the rest of the profil definitions.

          3. As mentioned when we introduced maven target to execute against embedded derby, we are still not able to execute/debug cpactf tests against this database engine within eclipse.

          At http://jira.codehaus.org/browse/CASTOR-2650 I like to address this 3 issues. Therefore I would appreciate if you could wait for some time to let me finish my work on this issue. I am quite confident that this will make support for maven profiles for cpactf much simpler.

          Show
          Ralf Joachim added a comment - I like the idea of maven profiles that will allow to execute cpactf through maven against different databases. There are only 3 points I do not like much at the current patch which uses maven-sql-plugin to setup database: 1. You have to add connection information for every database in pom.xml and cpactf-conf.xml. And they have to be in sync to execute tests successfully. 2. You have to add <srcFile>...</srcFile> definition in pom.xml for every database engine and every test. As we support 11 database engines and have about 85 tests this will lead us to around 1000 such definitions in pom.xml. In my opinon it will be a nightmare to maintain them. Not to forget the length of the rest of the profil definitions. 3. As mentioned when we introduced maven target to execute against embedded derby, we are still not able to execute/debug cpactf tests against this database engine within eclipse. At http://jira.codehaus.org/browse/CASTOR-2650 I like to address this 3 issues. Therefore I would appreciate if you could wait for some time to let me finish my work on this issue. I am quite confident that this will make support for maven profiles for cpactf much simpler.
          Hide
          Ralf Joachim added a comment -

          As Castor-2650 got fixed in the mean time we can continue with this one.

          Show
          Ralf Joachim added a comment - As Castor-2650 got fixed in the mean time we can continue with this one.

            People

            • Assignee:
              Ralf Joachim
              Reporter:
              Werner Guttmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: