castor

Execute ddl scripts with cpactf to enable testing against derby-embedded within eclipse

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3
  • Fix Version/s: 1.3.1
  • Component/s: JDO tests
  • Labels:
    None
  • Number of attachments :
    3
  1. Text File
    patch-C2650-20090505-01.txt
    04/May/09 7:04 PM
    17 kB
    Ralf Joachim
  2. Text File
    patch-C2650-20090505-02.txt
    04/May/09 7:04 PM
    128 kB
    Ralf Joachim
  3. Text File
    patch-C2650-20090509.txt
    09/May/09 8:57 AM
    424 kB
    Ralf Joachim

Issue Links

is depended upon by

Task - A task that needs to be done. CASTOR-2671 Add Maven profiles to CPACTF module

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Task - A task that needs to be done. CASTOR-2645 Set up cpactf tests running on Derby when building with Maven

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Resolved by using the maven-spl-plugin within the CPACTF POM.

Show
Werner Guttmann added a comment - Resolved by using the maven-spl-plugin within the CPACTF POM.
Hide
Permalink
Ralf Joachim added a comment -

No, this is not resolved by maven-sql-plugin.

Show
Ralf Joachim added a comment - No, this is not resolved by maven-sql-plugin.
Hide
Permalink
Werner Guttmann added a comment -

Oops, sorry, should have read the complete titel of the issue .. .

Show
Werner Guttmann added a comment - Oops, sorry, should have read the complete titel of the issue .. .
Hide
Permalink
Ralf Joachim added a comment -

Initial patch for review.

  • patch-C2650-20090505-01.txt contains changes to pom.xml, framework classes and configuration
  • patch-C2650-20090505-02.txt contains required changes to ddl scripts of derby and mysql

The patch allows to execute tests with maven against an embedded derby database. In addition test can be executed in eclipse against an embedded derby database or an mysql database server. For mysql it is now only required to setup the database but no scripts need to be executed any more as this is done by the test framework now. The remaining commands to execute against the mysql server prior to test execution are:

create database cpactf;
grant all on cpactf.* to 'test'@'localhost' identified by 'test';

Show
Ralf Joachim added a comment - Initial patch for review. patch-C2650-20090505-01.txt contains changes to pom.xml, framework classes and configuration patch-C2650-20090505-02.txt contains required changes to ddl scripts of derby and mysql The patch allows to execute tests with maven against an embedded derby database. In addition test can be executed in eclipse against an embedded derby database or an mysql database server. For mysql it is now only required to setup the database but no scripts need to be executed any more as this is done by the test framework now. The remaining commands to execute against the mysql server prior to test execution are: create database cpactf; grant all on cpactf.* to 'test'@'localhost' identified by 'test';
Hide
Permalink
Werner Guttmann added a comment -

Ralf, I just looked at the code for the first time, and I just wanted to have a few things confirmed:

a) we are not using SQL scripts anymore ?
b) DB tables are created using SQL statements created on the fly ?

Is this correct ?

Show
Werner Guttmann added a comment - Ralf, I just looked at the code for the first time, and I just wanted to have a few things confirmed: a) we are not using SQL scripts anymore ? b) DB tables are created using SQL statements created on the fly ? Is this correct ?
Hide
Permalink
Ralf Joachim added a comment -

Werner, we still need SQL scripts. Disadvantage is that we have to create separate scripts for setup (create table) and teardown (drop table) by hand. Advantage is that we do not need to execute them by hand and we do not need to add any script to pom.xml. We can also execute tests against an embedded derby database in eclipse.

I only separated the 2 patches for easier review of changes to code and scripts. If you like to test things, you have to apply both patches.

To get ride of the SQL scripts we will need to extend DDLGEN to be able to specify type and size of columns in mapping. In addition we will need to move definition of default records inserted from scripts to mapping or test cases.

Show
Ralf Joachim added a comment - Werner, we still need SQL scripts. Disadvantage is that we have to create separate scripts for setup (create table) and teardown (drop table) by hand. Advantage is that we do not need to execute them by hand and we do not need to add any script to pom.xml. We can also execute tests against an embedded derby database in eclipse. I only separated the 2 patches for easier review of changes to code and scripts. If you like to test things, you have to apply both patches. To get ride of the SQL scripts we will need to extend DDLGEN to be able to specify type and size of columns in mapping. In addition we will need to move definition of default records inserted from scripts to mapping or test cases.
Hide
Permalink
Ralf Joachim added a comment -

Final patch.

Show
Ralf Joachim added a comment - Final patch.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Ralf Joachim
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: