jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • castor
  • CASTOR-2569 annotation_processing Module
  • CASTOR-2636

Extend annotation processing framework to allow target aware processors and service (including base implementation)

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3.1
  • Component/s: JPA annotations
  • Labels:
    None
  • Testcase included:
    yes

Description

Added new TargetAwareAnnotationProcessor (plus service and downward compatible service base implementation)

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    patch-annotationprocessing-20090201.patch
    01/Feb/09 1:26 PM
    23 kB
    Peter Schmidt
  2. Text File
    patch-C2636-20090206.patch
    05/Feb/09 8:45 PM
    27 kB
    Peter Schmidt
  3. Text File
    patch-C2636-20090208.patch
    08/Feb/09 1:59 PM
    30 kB
    Peter Schmidt

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Werner Guttmann added a comment - 04/Feb/09 2:01 PM

Peter, can you please re-attach the patch, as I believe that there's missing code in the test case.

Show
Werner Guttmann added a comment - 04/Feb/09 2:01 PM Peter, can you please re-attach the patch, as I believe that there's missing code in the test case.
Hide
Permalink
Peter Schmidt added a comment - 05/Feb/09 8:45 PM

Eclipse messed with the patch file... which was good, because they didn't work properly anyway.
Now this is fixed.
Also: added ability of throwing a Mapping Exception if an Annotation is placed on a target where it should not be, instead of only returning false, which does not allow you to add further information about the reason of failure.

Show
Peter Schmidt added a comment - 05/Feb/09 8:45 PM Eclipse messed with the patch file... which was good, because they didn't work properly anyway. Now this is fixed. Also: added ability of throwing a Mapping Exception if an Annotation is placed on a target where it should not be, instead of only returning false, which does not allow you to add further information about the reason of failure.
Hide
Permalink
Werner Guttmann added a comment - 06/Feb/09 2:26 AM

Thanks, Peter. Will look into this in the afternoon, once I am on my train towards snow ... .

Show
Werner Guttmann added a comment - 06/Feb/09 2:26 AM Thanks, Peter. Will look into this in the afternoon, once I am on my train towards snow ... .
Hide
Permalink
Werner Guttmann added a comment - 06/Feb/09 4:13 PM

Okay, just following up my own email from the afternoon: whilst I like the idea with the use of the MappingException, this does not work as intended. The class MappingException is part of the XML module, and the core module (where the Annotation* classes live) must not depend upon the XML module. I have tried to move the MappingException class to the core module (within the same package, as this class is part of the public API) ... but then I get sealing exceptions.

As such, I'd introduce a new Exception (MappingException, but local to the annotation processing package(s), and then (somewhere else) convert this to the XML MappingException. I hope I have expressed myslef clearly .. ,.

Show
Werner Guttmann added a comment - 06/Feb/09 4:13 PM Okay, just following up my own email from the afternoon: whilst I like the idea with the use of the MappingException, this does not work as intended. The class MappingException is part of the XML module, and the core module (where the Annotation* classes live) must not depend upon the XML module. I have tried to move the MappingException class to the core module (within the same package, as this class is part of the public API) ... but then I get sealing exceptions. As such, I'd introduce a new Exception (MappingException, but local to the annotation processing package(s), and then (somewhere else) convert this to the XML MappingException. I hope I have expressed myslef clearly .. ,.
Hide
Permalink
Peter Schmidt added a comment - 08/Feb/09 1:59 PM

Ok. I introduced a new Exception within the annotation processing package, so this package is "stand alone".

Cheers, Peter

Show
Peter Schmidt added a comment - 08/Feb/09 1:59 PM Ok. I introduced a new Exception within the annotation processing package, so this package is "stand alone". Cheers, Peter

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Peter Schmidt
Vote (0)
Watch (0)

Dates

  • Created:
    01/Feb/09 1:19 PM
    Updated:
    30/Dec/09 4:21 AM
    Resolved:
    11/Feb/09 5:05 PM

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
45m
Time Spent - 45 minutes
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.