castor

Creating element type with NMTOKENS does not generate in correct package

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3 rc1
  • Fix Version/s: 1.3
  • Component/s: XML code generator
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    4

Description

When creating an element type instead of adding properties directly in the element so that the type can be reused there are problems for NMTOKENS. For example, the Details element from below does not get generated in the same package and location as DetailsIn. This does not happen if the restricted type is something else like int, string, etc.

          <xs:complexType>
			<xs:sequence>
				<xs:element name="DetailsOut" type="fsd:DetailType"></xs:element>
				<xs:element name="DetailsIn">
					<xs:simpleType>
						<xs:restriction base="xs:NMTOKENS">
							<xs:enumeration value="ZERO"></xs:enumeration>
							<xs:enumeration value="ONE"></xs:enumeration>
						</xs:restriction>
					</xs:simpleType>
				</xs:element>
			</xs:sequence>
	</xs:complexType>

        <xs:simpleType name="DetailType">
		<xs:restriction base="xs:NMTOKENS">
			<xs:enumeration value="TWO"></xs:enumeration>
			<xs:enumeration value="THREE"></xs:enumeration>
		</xs:restriction>
	</xs:simpleType>
  1. File
    castorbuilder.properties
    17/Nov/08 2:26 PM
    2 kB
    Renee Rivas
  2. Text File
    patch.c2578.20081118.txt
    18/Nov/08 2:14 PM
    0.6 kB
    Werner Guttmann
  3. XML File
    TokenExample.xsd
    17/Nov/08 2:24 PM
    2 kB
    Renee Rivas
  4. File
    TsbSchema.xpr
    17/Nov/08 2:25 PM
    0.3 kB
    Renee Rivas

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Renee Rivas added a comment -

I'm trying to research if there are specific properties I have to enable for these enumerations to work with nmtokens, and what happens if I make a list of them. Any other tips would be greatly appreciated!

Show
Renee Rivas added a comment - I'm trying to research if there are specific properties I have to enable for these enumerations to work with nmtokens, and what happens if I make a list of them. Any other tips would be greatly appreciated!
Hide
Permalink
Werner Guttmann added a comment -

Again, like with the other issue you raised, the work-around is to use elementFormDefault="qualified" with your schema. I agree that there seems to be a bug with unqualified, but it looks like this will be hard to resolve.

Show
Werner Guttmann added a comment - Again, like with the other issue you raised, the work-around is to use elementFormDefault="qualified" with your schema. I agree that there seems to be a bug with unqualified , but it looks like this will be hard to resolve.
Hide
Permalink
Werner Guttmann added a comment -

Btw, there's actually one more possible work-around. Instead of using namespace to package mappings, you could be using schema location to package mappings. In this case, it would not matter whether you are using qualified or unqualified as form default.

Show
Werner Guttmann added a comment - Btw, there's actually one more possible work-around. Instead of using namespace to package mappings, you could be using schema location to package mappings. In this case, it would not matter whether you are using qualified or unqualified as form default.
Hide
Permalink
Werner Guttmann added a comment -

Actually, sorry, even using qualified does not provide a valid work-around.

Show
Werner Guttmann added a comment - Actually, sorry, even using qualified does not provide a valid work-around.
Hide
Permalink
Renee Rivas added a comment -

I'm not sure what you mean by schema location to package mappings. Do you mean add the elements to the config files with the same package?

Show
Renee Rivas added a comment - I'm not sure what you mean by schema location to package mappings. Do you mean add the elements to the config files with the same package?
Hide
Permalink
Werner Guttmann added a comment -

Final patch for review.

Show
Werner Guttmann added a comment - Final patch for review.
Hide
Permalink
Renee Rivas added a comment -

should I download the latest source code, add this change and build it? Or will there be a snapshot released soon with this and any other recent patches?

Show
Renee Rivas added a comment - should I download the latest source code, add this change and build it? Or will there be a snapshot released soon with this and any other recent patches?
Hide
Permalink
Werner Guttmann added a comment -

As there's (finally, so to say) a few regression issues being reported with 1.3rc1, I'd rather delay an otherwise imminent release for about two weeks. As such, please feel free to checkout SVN trunk, apply the patch and test things yourself. Having said that, I shall make snapshot releases available at least twice a week for this period. In other words, your choice .. .

Show
Werner Guttmann added a comment - As there's (finally, so to say) a few regression issues being reported with 1.3rc1, I'd rather delay an otherwise imminent release for about two weeks. As such, please feel free to checkout SVN trunk, apply the patch and test things yourself. Having said that, I shall make snapshot releases available at least twice a week for this period. In other words, your choice .. .
Hide
Permalink
Werner Guttmann added a comment -

Actually, please ignore the misleading information I provided above re: the location to package mapping. I have been looking at some internal methods of SourceGenerator assuming that those are exposed publicly. My fault.

Show
Werner Guttmann added a comment - Actually, please ignore the misleading information I provided above re: the location to package mapping. I have been looking at some internal methods of SourceGenerator assuming that those are exposed publicly. My fault.
Hide
Permalink
Renee Rivas added a comment -

I tried downloading the 1.3rc1 source from http://dist.codehaus.org/castor/1.3rc1/, and also the current trunk, but both had build issues.

The rc1 had problems with SourceGenerator, which is odd since it had a jar out. Is there something special I need to do to build it?

Will you be posting the snapshot on snapshots.repository.codehaus.org?

Show
Renee Rivas added a comment - I tried downloading the 1.3rc1 source from http://dist.codehaus.org/castor/1.3rc1/ , and also the current trunk, but both had build issues. The rc1 had problems with SourceGenerator, which is odd since it had a jar out. Is there something special I need to do to build it? Will you be posting the snapshot on snapshots.repository.codehaus.org?
Hide
Permalink
Werner Guttmann added a comment -

With 1-3rc1 and higher, you can only use Maven to build Castor. Can I safely assume you have done that ? Yes, I will be posting a snapshot release once I have committed two issues.

Show
Werner Guttmann added a comment - With 1-3rc1 and higher, you can only use Maven to build Castor. Can I safely assume you have done that ? Yes, I will be posting a snapshot release once I have committed two issues.
Hide
Permalink
Renee Rivas added a comment -

yes, I was using maven 2.0.7, with mvn install and mvn package. I'll just wait for the snapshot. Will it require me to upgrade to snapshots of all the other castor libraries (xml, schema, etc)?

Show
Renee Rivas added a comment - yes, I was using maven 2.0.7, with mvn install and mvn package. I'll just wait for the snapshot. Will it require me to upgrade to snapshots of all the other castor libraries (xml, schema, etc)?
Hide
Permalink
Werner Guttmann added a comment -

yes, I was using maven 2.0.7, with mvn install and mvn package.

In that case I'd like to learn more about those problems. Feel like opening a new issue ?

Show
Werner Guttmann added a comment - yes, I was using maven 2.0.7, with mvn install and mvn package. In that case I'd like to learn more about those problems. Feel like opening a new issue ?
Hide
Permalink
Werner Guttmann added a comment -

Will it require me to upgrade to snapshots of all the other castor libraries (xml, schema, etc)?

Yes, pretty please. Just to be on the safe side of things .....

Show
Werner Guttmann added a comment - Will it require me to upgrade to snapshots of all the other castor libraries (xml, schema, etc)? Yes, pretty please. Just to be on the safe side of things .....

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Renee Rivas
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
1h 30m
Time Spent - 1 hour, 30 minutes