castor

Let KeyGenerator taken over role of SQLSatementCreate

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2
  • Fix Version/s: 1.3.1
  • Component/s: JDO queries
  • Labels:
    None
  • Number of attachments :
    2

Description

Subjetc says it all.

  1. PDF File
    sequence-key-generator.pdf
    25/Jul/09 1:39 PM
    25 kB
    Ralf Joachim
  2. PDF File
    sequence-key-generator.pdf
    25/Jul/09 11:40 AM
    23 kB
    Ralf Joachim

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. CASTOR-1728 "Duplicate key" exception with two simultaneous calls to Object.create(...)

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. CASTOR-2221 HighLowKeyGenerator throws an Exception on SQL Server 2005

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. CASTOR-1940 Support for JDBC 2 - PostgreSQL 8 (>7.2)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

New Feature - A new feature of the product, which has yet to be developed. CASTOR-977 provide an interface for programmatic generation of SQL queries

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
1.
 Refactor HighLow, Identity, Max and UUID key generators Sub-task Closed Closed Ralf Joachim
 
2.
 SQLException when lookup table of HighLow key generator is empty Sub-task Closed Closed Ralf Joachim
 
3.
 Refactor handling of KeyGenerator and extract ValueHandlers Sub-task Closed Closed Ralf Joachim
 
4.
 Move differences of database engines from IdentityKeyGenerator to PersistenceFactory Sub-task Closed Closed AHMAD HASSAN
 
5.
 Split SequenceKeyGenerator into 3 implementations handling one of the styles before, during and after Sub-task Closed Closed AHMAD HASSAN
 
6.
 Change logic for Oracle to use before instead of after key generator when neiter trigger nor returning is used Sub-task Closed Closed AHMAD HASSAN
 
7.
 Rename SQLStatementLookup to SQLStatementInsertCheck Sub-task Closed Closed AHMAD HASSAN
 
8.
 Change logic for PostgreSQL to retrieve generated key at SequenceAfterKeyGenerator Sub-task Closed Closed AHMAD HASSAN
 
9.
 Improve SQL class hierarchy to support insert queries Sub-task Closed Closed AHMAD HASSAN
 
10.
 Wrong syntax and missing quotation to retrieve generated keys for PostGreSQL Sub-task Closed Closed Ralf Joachim
 
11.
 Create abstract base classes for all key generators using same style Sub-task Closed Closed AHMAD HASSAN
 
12.
 Create key generator implementation and factory that does not generate key Sub-task Closed Closed AHMAD HASSAN
 
13.
 Improve SQLStatementInsertCheck similar to SQLStatementUpdateCheck Sub-task Closed Closed AHMAD HASSAN
 
14.
 Move executeStatementNoKeyGen() method from SQLStatementCreate to NoKeyGenerator Sub-task Closed Closed AHMAD HASSAN
 
15.
 Move executeStatementDuringInsert() method from SQLStatementCreate to SequenceDuringKeyGenerator Sub-task Closed Closed AHMAD HASSAN
 
16.
 Declare executeStatement Method in the KeyGenerator Interface Sub-task Closed Closed AHMAD HASSAN
 
17.
 Move executeStatementBeforeInsert() method from SQLStatementCreate to AbstractBeforeKeyGenerator Sub-task Closed Closed AHMAD HASSAN
 
18.
 Move executeStatementAfterInsert() method from SQLStatementCreate to AbstractAfterKeyGenerator Sub-task Closed Closed AHMAD HASSAN
 
19.
 Move buildStatement from SQLStatementCreate to Key Generators Sub-task Closed Closed AHMAD HASSAN
 
20.
 Builds statements with Insert class hierarchy where no special syntax is required Sub-task Closed Closed AHMAD HASSAN
 
21.
 Move common method to AbstractKeyGenerator and remove getStyle method from KeyGenerator Interface Sub-task Closed Closed AHMAD HASSAN
 
22.
 Move SQLStatementCreate to org.castor.cpa.persistence.sql.engine package. Sub-task Closed Closed AHMAD HASSAN
 
23.
 Improve SQL Insert class hierarchy to treat Sequence NextVal as an Expression Sub-task Closed Closed AHMAD HASSAN
 
24.
 Add missing javadoc to KeyGenerator interface and its implementations Sub-task Closed Closed AHMAD HASSAN
 
25.
 Add missing javadoc to KeyGeneratorTypeHandler interface and its implementations Sub-task Closed Closed AHMAD HASSAN
 
26.
 Improve SQLStatementInsertCheck to incorporate all the exception handling for executeStatement method of KeyGenerators. Sub-task Closed Closed AHMAD HASSAN
 
27.
 Move Database specific code from KeyGenerators to PersistenceFactory Sub-task Closed Closed AHMAD HASSAN
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ralf Joachim added a comment -

First part of refactoring.

Show
Ralf Joachim added a comment - First part of refactoring.
Hide
Permalink
Ralf Joachim added a comment -

Commented, attached file and closed wrong issue.

Show
Ralf Joachim added a comment - Commented, attached file and closed wrong issue.
Hide
Permalink
Ralf Joachim added a comment -

Fixed bug at HighLowKeyGenerator throwing exception if table for high low values is empty. I think this failure has been introduced at first refactoring step of this issue.

Show
Ralf Joachim added a comment - Fixed bug at HighLowKeyGenerator throwing exception if table for high low values is empty. I think this failure has been introduced at first refactoring step of this issue.
Hide
Permalink
Ralf Joachim added a comment -

Created subtasks for the work done already and moved attachements to these new subtasks.

Show
Ralf Joachim added a comment - Created subtasks for the work done already and moved attachements to these new subtasks.
Hide
Permalink
Ralf Joachim added a comment -

Let's see how code looks like after refactoring steps 4 to 7 before deciding about the next steps. ATM I think about creating abstract base classes for all key generators with the same style (before, during and after). Doing so would allow us to move code of SQLStatementCreate into this abstract key generators.

Show
Ralf Joachim added a comment - Let's see how code looks like after refactoring steps 4 to 7 before deciding about the next steps. ATM I think about creating abstract base classes for all key generators with the same style (before, during and after). Doing so would allow us to move code of SQLStatementCreate into this abstract key generators.
Hide
Permalink
Ralf Joachim added a comment -

Hi Ahmad, I have done a extensive analysis about sequence key generators. A PDF with the results is attached to this issue.

First page shows which database engines Castor currently supports. The columns are:

column description
1. Name of database engine.
2. Does checkSupportedFactory(PersistenceFactory) throw an exception.
3. - 6. Does logic in constructor throw an exception and if not which style will be used dependend on database engine, returning and trigger.
7. - 10. Does getValue() method throw an exception or does it return a value.
11. - 13. Does old/new test suite cover this use case or have it been tested in the past
14. For the use case not covered do I have used it at any time.

On second page I have provided the possibilities that I have found for the different database engines to use sequences including the SQL statements to execute.

Based upon this results I will now review logic of Castor.

Regards
Ralf

Show
Ralf Joachim added a comment - Hi Ahmad, I have done a extensive analysis about sequence key generators. A PDF with the results is attached to this issue. First page shows which database engines Castor currently supports. The columns are: column description 1. Name of database engine. 2. Does checkSupportedFactory(PersistenceFactory) throw an exception. 3. - 6. Does logic in constructor throw an exception and if not which style will be used dependend on database engine, returning and trigger. 7. - 10. Does getValue() method throw an exception or does it return a value. 11. - 13. Does old/new test suite cover this use case or have it been tested in the past 14. For the use case not covered do I have used it at any time. On second page I have provided the possibilities that I have found for the different database engines to use sequences including the SQL statements to execute. Based upon this results I will now review logic of Castor. Regards Ralf
Hide
Permalink
Ralf Joachim added a comment -

Improved version of the analysis with comments and conclusions. While change patch of CASTOR-2721 according to this and create new subtasks for further changes.

Show
Ralf Joachim added a comment - Improved version of the analysis with comments and conclusions. While change patch of CASTOR-2721 according to this and create new subtasks for further changes.
Hide
Permalink
Ralf Joachim added a comment -

Castor-977 demonstrates the original idea of a class hierarchy for SQL generation. Parts of this idea have been implemented with this issue.

Show
Ralf Joachim added a comment - Castor-977 demonstrates the original idea of a class hierarchy for SQL generation. Parts of this idea have been implemented with this issue.
Hide
Permalink
Ralf Joachim added a comment -

Major responsibilities of SQLStatementCreate have been moved to KeyGenerators. If more things to refactor in that area apear we will create a new issue for them.

Show
Ralf Joachim added a comment - Major responsibilities of SQLStatementCreate have been moved to KeyGenerators. If more things to refactor in that area apear we will create a new issue for them.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Ralf Joachim
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: