castor

Extract JDO annotations and fill {Class|Field}Infos using the proper Nature

Details

  • Number of attachments :
    6

Description

The task is about running through annotations, fetch JDO content from AppInfos and fill ClassInfos and FieldInfos using JDOClassNature and JDOFieldNature. Probably the best way to do so is within the SourceFactory's extractAnnotations method. Please keep in mind, that you need to apply the proper patch for annotation unmarshalling (CASTOR-2365).

  1. Text File
    patch.c2412.20080619.txt
    18/Jun/08 7:46 PM
    28 kB
    Sebastian Gabmeyer
  2. Text File
    patch.c2412.20080623.txt
    23/Jun/08 2:51 PM
    43 kB
    Sebastian Gabmeyer
  3. Text File
    patch.c2412.20080628.txt
    28/Jun/08 12:24 PM
    80 kB
    Werner Guttmann
  4. Text File
    patch.c2412.20080703.txt
    02/Jul/08 6:48 PM
    44 kB
    Sebastian Gabmeyer
  5. Text File
    patch.c2412.20080715.txt
    15/Jul/08 9:38 AM
    3 kB
    Filip Hianik
  6. Text File
    patch.c2412.20080720.txt
    20/Jul/08 2:17 PM
    1 kB
    Filip Hianik

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sebastian Gabmeyer added a comment -

This first patch realizes the goal of adding JDO-specific information obtained from AppInfos to ClassInfos and FieldInfos via JDOClassNature and JDOFieldNature, respectively. Two testcases are provided together with two 2 different schema files.

In order to get this patch running, two other patches need to be applied. The following steps outline this procedure:

1. Apply patch.c2365.20080605.txt from CASTOR-2365
2. Run a maven compile on the Castor Schema Projects (NOT on the entire project!)
3. Apply patch.c2380.20080610.txt from CASTOR-2380 (or download & extract the zip-file if you encounter problems during patching)
4. Finally apply this patch (patch.c2412.20080619.txt)

Show
Sebastian Gabmeyer added a comment - This first patch realizes the goal of adding JDO-specific information obtained from AppInfos to ClassInfos and FieldInfos via JDOClassNature and JDOFieldNature, respectively. Two testcases are provided together with two 2 different schema files. In order to get this patch running, two other patches need to be applied. The following steps outline this procedure: 1. Apply patch.c2365.20080605.txt from CASTOR-2365 2. Run a maven compile on the Castor Schema Projects (NOT on the entire project!) 3. Apply patch.c2380.20080610.txt from CASTOR-2380 (or download & extract the zip-file if you encounter problems during patching) 4. Finally apply this patch (patch.c2412.20080619.txt)
Sebastian Gabmeyer made changes -
Field Original Value New Value
Attachment patch.c2412.20080619.txt [ 35276 ]
Werner Guttmann made changes -
Assignee Werner Guttmann [ wguttmn ]
Hide
Permalink
Sebastian Gabmeyer added a comment -

After some testing within our team here in Vienna and our/my inability to reproduce a working test environment following the setup procedure from my last post I finally figured out the error:

Do not use patch.c2365.20080605.txt from CASTOR-2365 (as described in the first step). USE patch.c2395.20080606.txt from CASTOR-2395 instead!

Furthermore, please ensure that you run the maven compile with skip tests option set to true. If you want to make sure if you applied the patch from CASTOR-2395 correctly run the test cases that come with it (i.e. AppInfoUnmarshallerTest and SchemaUnmarshallerTest)

The rest of the procedure should be followed as described in my last post.

Sorry for the caused confusion!

Show
Sebastian Gabmeyer added a comment - After some testing within our team here in Vienna and our/my inability to reproduce a working test environment following the setup procedure from my last post I finally figured out the error: Do not use patch.c2365.20080605.txt from CASTOR-2365 (as described in the first step). USE patch.c2395.20080606.txt from CASTOR-2395 instead! Furthermore, please ensure that you run the maven compile with skip tests option set to true. If you want to make sure if you applied the patch from CASTOR-2395 correctly run the test cases that come with it (i.e. AppInfoUnmarshallerTest and SchemaUnmarshallerTest) The rest of the procedure should be followed as described in my last post. Sorry for the caused confusion!
Hide
Permalink
Sebastian Gabmeyer added a comment -

Reworked existing test cases. Added test cases for two additional schemas. Added documentation.
Follow the instructions found in the previous two comments to apply this patch successfully.

Show
Sebastian Gabmeyer added a comment - Reworked existing test cases. Added test cases for two additional schemas. Added documentation. Follow the instructions found in the previous two comments to apply this patch successfully.
Sebastian Gabmeyer made changes -
Attachment patch.c2412.20080623.txt [ 35360 ]
Hide
Permalink
Werner Guttmann added a comment -

Updated patch that compiles just fine and where the tests run successfully against the latest nature code (as committed as part of CASTOR-2380 a few hours ago).

Show
Werner Guttmann added a comment - Updated patch that compiles just fine and where the tests run successfully against the latest nature code (as committed as part of CASTOR-2380 a few hours ago).
Werner Guttmann made changes -
Attachment patch.c2412.20080628.txt [ 35460 ]
Hide
Permalink
Werner Guttmann added a comment -

A few observations:

Show
Werner Guttmann added a comment - A few observations: The patch just attached includes the patch from CASTOR-2395 as well. As such, I think that either CASTOR-2365 and/or CASTOR-2395 should be marked as resolved. Any objections ? What exactly is the relation between CASTOR-2365 and CASTOR-2395 ?
Hide
Permalink
Sebastian Gabmeyer added a comment -

This is a general update to the AppInfo processing to deal with the latest changes made to Natures and the AppInfoUnmarshaller. The included schemas and test cases were updated as well.

Show
Sebastian Gabmeyer added a comment - This is a general update to the AppInfo processing to deal with the latest changes made to Natures and the AppInfoUnmarshaller. The included schemas and test cases were updated as well.
Sebastian Gabmeyer made changes -
Attachment patch.c2412.20080703.txt [ 35556 ]
Permalink
Werner Guttmann logged work - 03/Jul/08 8:57 AM
  • Time Spent:
    20 minutes
     
    Patch integration.
Werner Guttmann made changes -
Time Spent 20 minutes [ 1200 ]
Werner Guttmann made changes -
Resolution Fixed [ 1 ]
Fix Version/s 1.2.1 [ 14004 ]
Status Open [ 1 ] Resolved [ 5 ]
Hide
Permalink
Filip Hianik added a comment -

Method processAppinfo() of SourceFactory extended that FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled.
Before applying this patch don't forget to apply patch.c2365.20080715.txt from CASTOR-2365

Show
Filip Hianik added a comment - Method processAppinfo() of SourceFactory extended that FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled. Before applying this patch don't forget to apply patch.c2365.20080715.txt from CASTOR-2365
Filip Hianik made changes -
Attachment patch.c2412.20080715.txt [ 35859 ]
Hide
Permalink
Filip Hianik added a comment -

Method processAppinfo() of SourceFactory extended -> properties readOnly and dirty of FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled.
Before applying this patch don't forget to apply:
patch.c2448.20080720.txt from CASTOR-2448
patch.c2469.20080720.txt from CASTOR-2469
patch.c2470.20080720.txt from CASTOR-2470

Show
Filip Hianik added a comment - Method processAppinfo() of SourceFactory extended -> properties readOnly and dirty of FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled. Before applying this patch don't forget to apply: patch.c2448.20080720.txt from CASTOR-2448 patch.c2469.20080720.txt from CASTOR-2469 patch.c2470.20080720.txt from CASTOR-2470
Filip Hianik made changes -
Attachment patch.c2412.20080720.txt [ 35973 ]
Permalink
Werner Guttmann logged work - 20/Jul/08 3:55 PM
  • Time Spent:
    10 minutes
     
    Patch integration.
Werner Guttmann made changes -
Time Spent 20 minutes [ 1200 ] 30 minutes [ 1800 ]
Werner Guttmann made changes -
Fix Version/s 1.3 rc1 [ 14613 ]
Fix Version/s 1.3 [ 14004 ]
Ralf Joachim made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Lukas Lang
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
45m
Original Estimate - 45 minutes Original Estimate - 45 minutes
Remaining:
45m
Time Spent - 30 minutes Remaining Estimate - 45 minutes
Logged:
30m
Time Spent - 30 minutes Remaining Estimate - 45 minutes