castor
  1. castor
  2. CASTOR-2412

Extract JDO annotations and fill {Class|Field}Infos using the proper Nature

    Details

    • Number of attachments :
      6

      Description

      The task is about running through annotations, fetch JDO content from AppInfos and fill ClassInfos and FieldInfos using JDOClassNature and JDOFieldNature. Probably the best way to do so is within the SourceFactory's extractAnnotations method. Please keep in mind, that you need to apply the proper patch for annotation unmarshalling (CASTOR-2365).

      1. patch.c2412.20080619.txt
        28 kB
        Sebastian Gabmeyer
      2. patch.c2412.20080623.txt
        43 kB
        Sebastian Gabmeyer
      3. patch.c2412.20080628.txt
        80 kB
        Werner Guttmann
      4. patch.c2412.20080703.txt
        44 kB
        Sebastian Gabmeyer
      5. patch.c2412.20080715.txt
        3 kB
        Filip Hianik
      6. patch.c2412.20080720.txt
        1 kB
        Filip Hianik

        Activity

        Hide
        Sebastian Gabmeyer added a comment -

        This first patch realizes the goal of adding JDO-specific information obtained from AppInfos to ClassInfos and FieldInfos via JDOClassNature and JDOFieldNature, respectively. Two testcases are provided together with two 2 different schema files.

        In order to get this patch running, two other patches need to be applied. The following steps outline this procedure:

        1. Apply patch.c2365.20080605.txt from CASTOR-2365
        2. Run a maven compile on the Castor Schema Projects (NOT on the entire project!)
        3. Apply patch.c2380.20080610.txt from CASTOR-2380 (or download & extract the zip-file if you encounter problems during patching)
        4. Finally apply this patch (patch.c2412.20080619.txt)

        Show
        Sebastian Gabmeyer added a comment - This first patch realizes the goal of adding JDO-specific information obtained from AppInfos to ClassInfos and FieldInfos via JDOClassNature and JDOFieldNature, respectively. Two testcases are provided together with two 2 different schema files. In order to get this patch running, two other patches need to be applied. The following steps outline this procedure: 1. Apply patch.c2365.20080605.txt from CASTOR-2365 2. Run a maven compile on the Castor Schema Projects (NOT on the entire project!) 3. Apply patch.c2380.20080610.txt from CASTOR-2380 (or download & extract the zip-file if you encounter problems during patching) 4. Finally apply this patch (patch.c2412.20080619.txt)
        Hide
        Sebastian Gabmeyer added a comment -

        After some testing within our team here in Vienna and our/my inability to reproduce a working test environment following the setup procedure from my last post I finally figured out the error:

        Do not use patch.c2365.20080605.txt from CASTOR-2365 (as described in the first step). USE patch.c2395.20080606.txt from CASTOR-2395 instead!

        Furthermore, please ensure that you run the maven compile with skip tests option set to true. If you want to make sure if you applied the patch from CASTOR-2395 correctly run the test cases that come with it (i.e. AppInfoUnmarshallerTest and SchemaUnmarshallerTest)

        The rest of the procedure should be followed as described in my last post.

        Sorry for the caused confusion!

        Show
        Sebastian Gabmeyer added a comment - After some testing within our team here in Vienna and our/my inability to reproduce a working test environment following the setup procedure from my last post I finally figured out the error: Do not use patch.c2365.20080605.txt from CASTOR-2365 (as described in the first step). USE patch.c2395.20080606.txt from CASTOR-2395 instead! Furthermore, please ensure that you run the maven compile with skip tests option set to true. If you want to make sure if you applied the patch from CASTOR-2395 correctly run the test cases that come with it (i.e. AppInfoUnmarshallerTest and SchemaUnmarshallerTest) The rest of the procedure should be followed as described in my last post. Sorry for the caused confusion!
        Hide
        Sebastian Gabmeyer added a comment -

        Reworked existing test cases. Added test cases for two additional schemas. Added documentation.
        Follow the instructions found in the previous two comments to apply this patch successfully.

        Show
        Sebastian Gabmeyer added a comment - Reworked existing test cases. Added test cases for two additional schemas. Added documentation. Follow the instructions found in the previous two comments to apply this patch successfully.
        Hide
        Werner Guttmann added a comment -

        Updated patch that compiles just fine and where the tests run successfully against the latest nature code (as committed as part of CASTOR-2380 a few hours ago).

        Show
        Werner Guttmann added a comment - Updated patch that compiles just fine and where the tests run successfully against the latest nature code (as committed as part of CASTOR-2380 a few hours ago).
        Hide
        Werner Guttmann added a comment -

        A few observations:

        Show
        Werner Guttmann added a comment - A few observations: The patch just attached includes the patch from CASTOR-2395 as well. As such, I think that either CASTOR-2365 and/or CASTOR-2395 should be marked as resolved. Any objections ? What exactly is the relation between CASTOR-2365 and CASTOR-2395 ?
        Hide
        Sebastian Gabmeyer added a comment -

        This is a general update to the AppInfo processing to deal with the latest changes made to Natures and the AppInfoUnmarshaller. The included schemas and test cases were updated as well.

        Show
        Sebastian Gabmeyer added a comment - This is a general update to the AppInfo processing to deal with the latest changes made to Natures and the AppInfoUnmarshaller. The included schemas and test cases were updated as well.
        Hide
        Filip Hianik added a comment -

        Method processAppinfo() of SourceFactory extended that FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled.
        Before applying this patch don't forget to apply patch.c2365.20080715.txt from CASTOR-2365

        Show
        Filip Hianik added a comment - Method processAppinfo() of SourceFactory extended that FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled. Before applying this patch don't forget to apply patch.c2365.20080715.txt from CASTOR-2365
        Hide
        Filip Hianik added a comment -

        Method processAppinfo() of SourceFactory extended -> properties readOnly and dirty of FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled.
        Before applying this patch don't forget to apply:
        patch.c2448.20080720.txt from CASTOR-2448
        patch.c2469.20080720.txt from CASTOR-2469
        patch.c2470.20080720.txt from CASTOR-2470

        Show
        Filip Hianik added a comment - Method processAppinfo() of SourceFactory extended -> properties readOnly and dirty of FieldInfos with JDOOneToOneNature and JDOOneToManyNature can be filled. Before applying this patch don't forget to apply: patch.c2448.20080720.txt from CASTOR-2448 patch.c2469.20080720.txt from CASTOR-2469 patch.c2470.20080720.txt from CASTOR-2470

          People

          • Assignee:
            Werner Guttmann
            Reporter:
            Lukas Lang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 45 minutes Original Estimate - 45 minutes
              45m
              Remaining:
              Time Spent - 30 minutes Remaining Estimate - 45 minutes
              45m
              Logged:
              Time Spent - 30 minutes Remaining Estimate - 45 minutes
              30m