jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • castor
  • CASTOR-2405

Refactor FieldMemberAndAccess Class to use FieldInfo methods were appropriate

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3 rc1
  • Component/s: XML code generator
  • Labels:
    None

Description

This is a refactoring task aiming to replace custom implementations of functions which are already defined within FieldInfo (so to say, have the same functionality/result). For example, in the FieldMemberAndAccess#createGetterMethod(..) the getter-name is constructed by:

String mname = fieldInfo.getMethodSuffix();
...
method = new JMethod(FieldInfo.METHOD_PREFIX_GET + mname, jType,"the value of field '" + mname + "'.");

The bold text should be replaced by fieldInfo.getReadMethod which does exactly the same as above.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    patch.c2405.20080603.txt
    03/Jun/08 9:50 AM
    6 kB
    Sebastian Gabmeyer

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Sebastian Gabmeyer added a comment - 03/Jun/08 9:49 AM

Of course I meant the FieldMemberAndAccessorFactory; sorry for the caused confusion!

Show
Sebastian Gabmeyer added a comment - 03/Jun/08 9:49 AM Of course I meant the FieldMemberAndAccessorFactory; sorry for the caused confusion!

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Sebastian Gabmeyer
Vote (0)
Watch (0)

Dates

  • Created:
    03/Jun/08 9:38 AM
    Updated:
    24/Jan/09 11:12 AM
    Resolved:
    06/Jun/08 4:48 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.