jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • castor
  • CASTOR-2283

Throw away static initialization of XMLClassDescriptorImpl

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.3 rc1
  • Component/s: None
  • Labels:
    None
  • Environment:
    all

Description

Currently XMLClassDecriptorImpl has a static attribute _naming which is statically initialized and used just once in the method toXMLName.

I want to remove this as e.g. JAXB works with a different naming then Castor itself - and also I personally dislike static stuff.

I already changed the code (I'll attach the patch soon) and did some tests and everything works fine.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    patch-c2283-20080130.txt
    30/Jan/08 5:59 PM
    7 kB
    Joachim Grüneis

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Joachim Grüneis added a comment - 30/Jan/08 5:59 PM

I simply removed the static stuff - checked if all calls to toXMLName are done with already a generated xml name at hand and... everything looks good, all tests are successful!

Show
Joachim Grüneis added a comment - 30/Jan/08 5:59 PM I simply removed the static stuff - checked if all calls to toXMLName are done with already a generated xml name at hand and... everything looks good, all tests are successful!

People

  • Assignee:
    Joachim Grüneis
    Reporter:
    Joachim Grüneis
Vote (0)
Watch (0)

Dates

  • Created:
    30/Jan/08 3:57 AM
    Updated:
    24/Jan/09 11:13 AM
    Resolved:
    06/Feb/08 4:16 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.