History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CASTOR-2255
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Joachim Grüneis
Reporter: Joachim Grüneis
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
castor

Introduce an interface XMLNaming instead of todays abstract class which will be named AbstractXMLNaming

Created: 07/Jan/08 05:28 AM   Updated: 07/Jan/08 10:30 AM
Component/s: None
Affects Version/s: 1.1.2.1
Fix Version/s: None

Time Tracking:
Not Specified

Environment: all


 Description  « Hide
Today the class to create valid XML names is XMLNaming which is abstract and its implementation DefaultNaming. The naming class is created either via:
*) configuration or
*) XMLNaming.getInstance (which internally redirects to configuration...)

I would like to introduce an interface XMLNaming, which reflects the methods to implement for XML naming creation.
And rename current XMLNaming to AbstractXMLNaming.

I will do this change in two steps because otherwise SVN will be confused:
1) rename XMLNaming to AbstractXMLNaming
2) introduce XMLNaming interface and use it in every place AbstractXMLNaming is used.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Werner Guttmann - 07/Jan/08 07:52 AM
Absolutely fine by me. Anything that moves away from this use of abstract classes rather than interfaces is .. wonderful.

Joachim Grüneis - 07/Jan/08 10:30 AM
Renamed XMLNaming to AbstractXMLNaming (commit 7357)
Introduced interface XMLNaming for AbstractXMLNaming (commit 7358)
Moved XMLNaming to org.castor.xml (commit 7359)
Adapted castor-jaxb-2.0 to new interface (commit 7360)