castor

unmarshal() method in subtype should return subtype.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.2.1
  • Fix Version/s: 1.2
  • Component/s: XML
  • Labels:
    None
  • Number of attachments :
    2

Description

Thread: http://www.nabble.com/unmarshal%28%29-method-for-named-element-with-%27type%27-attribute-tf4681201.html

Actually, I just learned myself that what I have said is valid for Java
1.4 and below only. With java 5.0 and baove, this will be possible.

As such, can you please create a new Jira issue, asking us to support this.

Regards
Werner 

<?xml version="1.0" encoding="UTF-8"?>
<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema" version="1.0.0">
        <xsd:element name="AKConfig" type="AKConfigType">
                <xsd:annotation>
                        <xsd:documentation>AK Config</xsd:documentation>
                </xsd:annotation>
        </xsd:element>
        <xsd:complexType name="AKConfigType">
                <xsd:sequence>
                        <xsd:element name="handler" type="xsd:string" />
                        <xsd:element name="timeout" type="xsd:int" />
                        <xsd:element name="allowMultiplePartsPerCnxn" type="xsd:boolean" default="false" />
                        <xsd:element name="CategoryList" type="CategoryListType" />
                </xsd:sequence>
        </xsd:complexType>
        <xsd:complexType name="CategoryListType">
                <xsd:sequence>
                        <xsd:element name="CnxnCategory" type="CategoryType" minOccurs="0" maxOccurs="unbounded" />
                </xsd:sequence>
        </xsd:complexType>
        <xsd:complexType name="CategoryType">
                <xsd:attribute name="value" type="xsd:string" use="required" />
                <xsd:attribute name="MaxConnectionsAllowed" type="xsd:int" use="optional" default="1" />
        </xsd:complexType>
</xsd:schema>

In the generated AKConfig.java, the unmarshal() method is:

public static com.ak.castor.AKConfigType unmarshal(
            final java.io.Reader reader)
    throws org.exolab.castor.xml.MarshalException, org.exolab.castor.xml.ValidationException {
        return (com.ak.castor.AKConfigType) Unmarshaller.unmarshal(com.ak.castor.AKConfig.class, reader);
    }

Why does this method return AKConfigType, and not AKConfig?

  1. Text File
    patch.cstaticunmarshal.20071025.txt
    26/Oct/07 3:04 PM
    2 kB
    Werner Guttmann
  2. Text File
    patch.c2209.20071029.txt
    29/Oct/07 5:02 AM
    1.0 kB
    Werner Guttmann

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Aslam Karachiwala added a comment -

Even with JDK 1.4, shouldn't the type cast in the return statement be to the subtype?

return (com.ak.castor.AKConfig) Unmarshaller.unmarshal(com.ak.castor.AKConfig.class, reader);
Show
Aslam Karachiwala added a comment - Even with JDK 1.4, shouldn't the type cast in the return statement be to the subtype? return (com.ak.castor.AKConfig) Unmarshaller.unmarshal(com.ak.castor.AKConfig.class, reader);
Hide
Permalink
Werner Guttmann added a comment -

If you tried that with Java 1.4, you'd get compilation errors. Sorry .. ;-.(. All I can do is to generate the 'right' code for Java 5.0 and above.

Show
Werner Guttmann added a comment - If you tried that with Java 1.4, you'd get compilation errors. Sorry .. ;-.(. All I can do is to generate the 'right' code for Java 5.0 and above.
Hide
Permalink
Werner Guttmann added a comment -

Patch identifying the problem area.

Show
Werner Guttmann added a comment - Patch identifying the problem area.
Hide
Permalink
Werner Guttmann added a comment -

Can you please attach a sample XML document instance that matches the XML schema given ? I'd like to add a new test case to the CTF suite as a result of this bug.

Show
Werner Guttmann added a comment - Can you please attach a sample XML document instance that matches the XML schema given ? I'd like to add a new test case to the CTF suite as a result of this bug.
Hide
Permalink
Werner Guttmann added a comment -

Initial patch for review.

Show
Werner Guttmann added a comment - Initial patch for review.
Hide
Permalink
Werner Guttmann added a comment - - edited

As a result of this patch, the following unmarshal method() will be generated in the class CnxnCatgeory.java with Java 5.0 enabled via builder properties:

    public static xml.c2209.generated.CnxnCategory unmarshal(
            final java.io.Reader reader)
    throws org.exolab.castor.xml.MarshalException, org.exolab.castor.xml.ValidationException {
        return (xml.c2209.generated.CnxnCategory) Unmarshaller.unmarshal(xml.c2209.generated.CnxnCategory.class, reader);
    }
Show
Werner Guttmann added a comment - - edited As a result of this patch, the following unmarshal method() will be generated in the class CnxnCatgeory.java with Java 5.0 enabled via builder properties: public static xml.c2209.generated.CnxnCategory unmarshal( final java.io.Reader reader) throws org.exolab.castor.xml.MarshalException, org.exolab.castor.xml.ValidationException { return (xml.c2209.generated.CnxnCategory) Unmarshaller.unmarshal(xml.c2209.generated.CnxnCategory.class, reader); }
Hide
Permalink
Werner Guttmann added a comment -

I still need to update the release notes to make this change (more) explicit, as clearly it changes an outbound contract (again).

Show
Werner Guttmann added a comment - I still need to update the release notes to make this change (more) explicit, as clearly it changes an outbound contract (again).
Hide
Permalink
Werner Guttmann added a comment -

Aslam, have you been able to have a look at this patch ?

Show
Werner Guttmann added a comment - Aslam, have you been able to have a look at this patch ?
Hide
Permalink
Aslam Karachiwala added a comment -

Looks good. Will attach the the XML/XSD example.

Show
Aslam Karachiwala added a comment - Looks good. Will attach the the XML/XSD example.
Hide
Permalink
Aslam Karachiwala added a comment -

XML example for the schema above:

<?xml version="1.0" encoding="UTF-8"?>
<AKConfig xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="AKConfig.xsd">
  <handler>handler</handler>
  <timeout>0</timeout>
  <allowMultiplePartsPerCnxn>false</allowMultiplePartsPerCnxn>
  <CategoryList>
    <CnxnCategory MaxConnectionsAllowed="1" value=""/>
  </CategoryList>
</AKConfig>
Show
Aslam Karachiwala added a comment - XML example for the schema above: <?xml version= "1.0" encoding= "UTF-8" ?> <AKConfig xmlns:xsi = "http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation= "AKConfig.xsd" > <handler> handler </handler> <timeout> 0 </timeout> <allowMultiplePartsPerCnxn> false </allowMultiplePartsPerCnxn> <CategoryList> <CnxnCategory MaxConnectionsAllowed= "1" value=""/> </CategoryList> </AKConfig>
Hide
Permalink
Werner Guttmann added a comment -

Thanks. Should be able to commit this patch soon-ish.

Show
Werner Guttmann added a comment - Thanks. Should be able to commit this patch soon-ish.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Aslam Karachiwala
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: