castor
  1. castor
  2. CASTOR-2119

Remove logic from LocalConfiguration and put it into XMLContext

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Component/s: XML
    • Labels:
      None
    • Number of attachments :
      6

      Description

      Currently LocalConfiguration is responsible to:
      1) provide access to configuration properties and
      2) provide some methods that are largely used in the framework and
      3) keeping states of processing...
      that is to much!

      Also LocalConfiguration is accessed in a static way which leads to trouble in multithreded environments.

      The new Configuration (which is already available) is pure again only providing access to configuration properties - a good step!

      Now a place is needed to put the other responsibilities of curent LocalConfiguration.

      My approach is to use XMLContext for this stuff.
      And in addition I try to remove as much static access as possible - for the sake of thread-safe-ness and such.

      1. castor-XMLContext-20070820.txt
        209 kB
        Joachim Grüneis
      2. patch.CASTOR-2119.20070828-1112.txt
        270 kB
        Joachim Grüneis
      3. patch-c2119-20070922-1236.txt
        446 kB
        Joachim Grüneis
      4. patch-c2119-20070922-1339.txt
        453 kB
        Joachim Grüneis
      5. patch-c2119-20070928.txt
        353 kB
        Joachim Grüneis
      6. patch-c2119-20071001.txt
        356 kB
        Joachim Grüneis

        Issue Links

          Activity

          Hide
          Joachim Grüneis added a comment -

          The big introspector refactoring is in Issue 2084. The introspector modifications in this issue are only related to the introduction of InternalContext.

          Show
          Joachim Grüneis added a comment - The big introspector refactoring is in Issue 2084. The introspector modifications in this issue are only related to the introduction of InternalContext.
          Hide
          Joachim Grüneis added a comment -

          Now I've switched to work with JDK1.4.2 as there had been some problems that haven't occured working with JDK1.5 . I fixed all problems but one. The last test that still fails is:
          marshalling/xsi-type
          I'll be looking at it later today - I just wanted to have a version in jira and show some progress.

          Show
          Joachim Grüneis added a comment - Now I've switched to work with JDK1.4.2 as there had been some problems that haven't occured working with JDK1.5 . I fixed all problems but one. The last test that still fails is: marshalling/xsi-type I'll be looking at it later today - I just wanted to have a version in jira and show some progress.
          Hide
          Joachim Grüneis added a comment -

          Please see mail thread 'xsi:type handling and CASTOR-2119' on castor-dev where I started to discuss the topic of the last test that fails...

          Show
          Joachim Grüneis added a comment - Please see mail thread 'xsi:type handling and CASTOR-2119 ' on castor-dev where I started to discuss the topic of the last test that fails...
          Hide
          Joachim Grüneis added a comment -

          This patch works! No more failing tests. I've manipulated the test case to clear the descriptor cache.

          Show
          Joachim Grüneis added a comment - This patch works! No more failing tests. I've manipulated the test case to clear the descriptor cache.
          Hide
          Werner Guttmann added a comment -

          Committed as is. Thanks, Joachim, for this work. And your patience with me being super-pessimistic during the last few weeks.

          Show
          Werner Guttmann added a comment - Committed as is. Thanks, Joachim, for this work. And your patience with me being super-pessimistic during the last few weeks.

            People

            • Assignee:
              Joachim Grüneis
              Reporter:
              Joachim Grüneis
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: