Move field and method creation code out of FieldInfos into FieldMemberAndAccessorFactorys

This patch moves the code into new FieldMemberAndAccessorFactories
In addition, the source generator is changed to generate java 5 enums if useJava5 is true

Looking at this one it again seams to me that you have not separated differnet issues as this patch also includes the enum changes.

For the extraction of the creation code of properties and accessor methods I'd like to understand the driver behind. Without a deep analysis of your changes it seams that you simply moved the code into other classes or does the patch also include changes of the generation logic or generated methods. If you did not only move code to the factories could you please explain the additional changes? In addition I'm interested to hear about the advantage of the approach you have choosen? Wouldn't it be better to move the creation code for accessors into various extensions of JMethod (e.g JMethodSet, JMethodGet, JMethodIterate) as your current factories are still quite long?

After commit of CASTOR-2104 this patch neds to be updated. I tried to do so but it seams I lost something at merge as I get compile errors running our test suite. My guess is that collection accessors are not generated. On request I can publish that patch as a starting point.

I will update this patch later today. In fact, I will reorganize my patches (enums etc.) to current trunk and will post them in addition with with detailed information in jira/mailinglist.

I finally managed to create an isolated patch for this issue against current castor trunk.

I think it will be easier to talk about the details now, so I want to explain what this patch is about:

This patch is actually just a structural cleanup. While starting to think about the jaxb2 annotation integration, I tried to discover where to put the hooks for this task. IMHO the best places for this are where the Class/FieldInfos are translated into JClass/JFields. There we discovered some inconsistency, because ClassInfo, GroupInfo etc. are simple POJO style containers with the exception of the FieldInfo classes. So we decided to move the creation code to factory classes (like the SourceFactory for JClasses).

Can you please create a follow-up issue that deals with the (missing) refactoring of the CollectionInfoJ2SortedSet class. I decided to commit the patch as is (with one or two minor modifications), as it will be easier for you to post (dependent) patches after this commit.

I attached the additional patch that removes the unused methods in CollectionInfoJ2SortedSet

Thanks, Matthias. But shouldn't the removed methods be moved to a new factory class similar to all other CollectionInfo* types ? Just wondering aloud .. :

In addition, can you please create a new 'follow-up' task and move all new factories to a new package info.factory or factory.info .. whatever your preference is.

it exists a CollectionJ2NoIndexMemberAndAccessorFactory that simply implements the methods and supresses the creation of the index methods. this factory is used for all collection subtypes that need this behaviour