|
|
|
[
Permlink
| « Hide
]
Werner Guttmann - 09/Aug/07 07:04 AM
Initial patch for review.
Whilst this patch resolves the issue at hand, it also breaks compatibility with older versions of Castor. As such, re-generation of classes is a necessity, and the XML instance documents will have to be altered as well. In other words, this is a blocker, and the solution introduces a break. But I don't see any other way how to go about this.
Ron, could you please attach a sample XML document that in your view should successfully unmarshall against the classes generated from your XML schema ? I need to build a test case to avoid future regression issues in this code area.
Here is a sample XML file created by a server with generated code based on Castor 0.9.9. Please note the element DateDue which is the choice that the newer version is having problems with.
Here is a sample XML file created by a server with generated code based on Castor 0.9.9. Please note the element DateDue which is the choice that the newer version is having problems with.
Rom, the XML document instance you attached does not match the XML schema you've attached previously. Either you attach a new XML schema instance that validates against the XML given, or you re-attach a new sample XML document instance that matches the XML schema. Your choice ...
Ron, I am basically ready to commit the patch as is (though I will have to add some documentation as we are changing Castor's functional behavior), but without a proper test to be added to Castor's internal test suite, I won't be able to proceed.
Werner, here is another version of the schema and I'll attach another version of the XML that conforms to this. Hopefully, you can use this for your test.
Werner, this is a new version of the XML that conforms to the ncip_short_schema.xsd. This, hopefully, will work for your test. Thanks.
Final patch that adds a new test to the CTF suite.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||