castor

Marshalling to DOM does not handle namespaces

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.9.3.21
  • Fix Version/s: None
  • Component/s: XML
  • Labels:
    None
  • Environment:
    Operating System: All
    Platform: PC
  • Bugzilla Id:
    1056
  • Number of attachments :
    1

Description

XML Environment: Xerces 1.4.4, Xalan-J 2.4

Occurs when marshalling a Castor object to a DOM Document via the Marshaller class.

The resulting DOM document has elements with local names such as
"prefix:element". This causes a DOM003 namespace error whenever using the DOM
document for any processing, such as XSLT transforms. This occurs because the
transfomer is not expecting a ":" to be in the local name. However, serializing
the DOM document works OK.

Note that SAX2DOMHandler always calls createElement rather than calling
createElementNS if the element has a namespace.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Keith Visco added a comment -

SAX2DOMHandler was created primarily for DOM1, it needs to handle the namespaces
properly or be upgraded to a newer DOM version. Assigning to Arnaud!

Show
Keith Visco added a comment - SAX2DOMHandler was created primarily for DOM1, it needs to handle the namespaces properly or be upgraded to a newer DOM version. Assigning to Arnaud!
Hide
Permalink
Eric Kow added a comment -

Not being able to wait for namespace support (i need it for my job), and not
having found it in the code from the CVS repository, i have taken it upon myself
to upgrade Castor to use SAX2 instead of SAX1.

It looked easy, but now it feels like unraveling a sweater just by pulling this
one teensy eeensy thread.

That being said, is there a branch i should check out where this work is already
being done so that i don't drop too many hours down the path of duplicate work?

If not, is CVS fine-grained enough that you could create such a branch and give
me commit access to just that branch?

Show
Eric Kow added a comment - Not being able to wait for namespace support (i need it for my job), and not having found it in the code from the CVS repository, i have taken it upon myself to upgrade Castor to use SAX2 instead of SAX1. It looked easy, but now it feels like unraveling a sweater just by pulling this one teensy eeensy thread. That being said, is there a branch i should check out where this work is already being done so that i don't drop too many hours down the path of duplicate work? If not, is CVS fine-grained enough that you could create such a branch and give me commit access to just that branch?
Hide
Permalink
Anand Krishnan added a comment -

I made managed to fix this problem by folding SAX2DOMHandler into DocumentHandlerAdapter to create a new class, SAX2DOMContentHandler which handles namespaces as per SAX2 parsers. This is a first pass implementation. Thus I may have preserved some unnecessary namespace handling-related code from the original DocumentHandlerAdapter implementation. Please take a look (see attached).

Here is its usage in Marshaller.java: (notice i moved the _handler assignment below the initialize() method invocation.)

public Marshaller( Node node )
{
if ( node == null )
throw new IllegalArgumentException( "Argument 'node' is null." );
_node = node;

// call internal initializer
initialize();

if (Boolean.valueOf(_config.getProperty(Configuration.Property.Namespaces, "false")).booleanValue())

{ _handler = new SAX2DOMContentHandler(node); }

else

{ _handler = new DocumentHandlerAdapter(new SAX2DOMHandler(node)); }

} //-- Marshaller

Show
Anand Krishnan added a comment - I made managed to fix this problem by folding SAX2DOMHandler into DocumentHandlerAdapter to create a new class, SAX2DOMContentHandler which handles namespaces as per SAX2 parsers. This is a first pass implementation. Thus I may have preserved some unnecessary namespace handling-related code from the original DocumentHandlerAdapter implementation. Please take a look (see attached). Here is its usage in Marshaller.java: (notice i moved the _handler assignment below the initialize() method invocation.) public Marshaller( Node node ) { if ( node == null ) throw new IllegalArgumentException( "Argument 'node' is null." ); _node = node; // call internal initializer initialize(); if (Boolean.valueOf(_config.getProperty(Configuration.Property.Namespaces, "false")).booleanValue()) { _handler = new SAX2DOMContentHandler(node); } else { _handler = new DocumentHandlerAdapter(new SAX2DOMHandler(node)); } } //-- Marshaller

People

  • Assignee:
    Werner Guttmann
    Reporter:
    rocketraman
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: