Details
Bug
Major
Description
The isValidated, addValidated, and removeValidated methods within org.exolab.castor.xml.ValidationContext are all performing string concatination by calling the toString method of the object that is passed in to each of these methods.
This is causing serious performance problems (as we are pushing through tremendous load) and did not exist in version 1.0 and prior.
Here is an example of one of the problem lines of code that exists:
LOG.trace("Called isValidated(" + object + ")");
This should be checking the isTraceEnabled method before wasting processing on this concatination, like so:
if (LOG.isTraceEnabled())
LOG.trace("Called isValidated(" + object + ")");
Issue Links
| This issue is related to: | ||||
| CASTOR-2013 | Wasting processing time on string concatenation in log statements |
|
|
|
I'm glad this is fixed. It was a performance killer for us. We had to hack the jar with different version.