castor

NumberFormatException: For input string: "10g"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.1
  • Fix Version/s: 1.3 rc1
  • Component/s: JDO
  • Labels:
    None
  • Environment:
    Windows XP, JDK 1.5, Oracle 10g
  • Number of attachments :
    1

Description

By using of LIMIT clause check castor the Oracle version. castor expected version like a number, but Oracle 10g returns "10g" version which is a cause of following exception:

java.lang.NumberFormatException: For input string: "10g"
at java.lang.NumberFormatException.forInputString(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at org.exolab.castor.jdo.DbMetaInfo.compareVersionStrings(DbMetaInfo.java:158)
at org.exolab.castor.jdo.DbMetaInfo.compareDbVersion(DbMetaInfo.java:143)
at org.exolab.castor.jdo.drivers.OracleQueryExpression.isLimitClauseSupported(OracleQueryExpression.java:197)
at org.exolab.castor.jdo.drivers.JDBCQueryExpression.addLimitClause(JDBCQueryExpression.java:282)
at org.exolab.castor.jdo.oql.ParseTreeWalker.addLimitClause(ParseTreeWalker.java:1160)
at org.exolab.castor.jdo.oql.ParseTreeWalker.createQueryExpression(ParseTreeWalker.java:952)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Fuchs added a comment -

The attached patch fixes recognition of Oracle 10g databases in the class DbMetaInfo. It is implemented by searching for the word "Release" in the full database version string and taking the following number expression. Als fallback solution the old algorithm, which just looks for the first numeric word, is also preserved.

I also inserted two examples of real Oracle product names, like they are returned by the JDBC driver, for better understanding of the algorithm and its problems.

Show
Martin Fuchs added a comment - The attached patch fixes recognition of Oracle 10g databases in the class DbMetaInfo. It is implemented by searching for the word "Release" in the full database version string and taking the following number expression. Als fallback solution the old algorithm, which just looks for the first numeric word, is also preserved. I also inserted two examples of real Oracle product names, like they are returned by the JDBC driver, for better understanding of the algorithm and its problems.
Martin Fuchs made changes -
Field Original Value New Value
Attachment castor-oracle-10g-limit.patch [ 30615 ]
Hide
Permalink
Ralf Joachim added a comment -

Patch of Martin looks good. Will try to include the patch for 1.2.

Show
Ralf Joachim added a comment - Patch of Martin looks good. Will try to include the patch for 1.2.
Ralf Joachim made changes -
Assignee Ralf Joachim [ rjoachim ]
Fix Version/s 1.2 [ 13559 ]
Werner Guttmann made changes -
Fix Version/s 1.2.1 [ 13817 ]
Fix Version/s 1.2 [ 13559 ]
Hide
Permalink
Ralf Joachim added a comment -

Commited patch as is

Show
Ralf Joachim added a comment - Commited patch as is
Ralf Joachim made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.2.1 [ 14004 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.2.2 [ 13817 ]
Werner Guttmann made changes -
Fix Version/s 1.3 rc1 [ 14613 ]
Fix Version/s 1.3 [ 14004 ]
Ralf Joachim made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Radovana Straube
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: