castor
  1. castor
  2. CASTOR-1932

Split ClassDescriptorResolver to be more expandable for future needs

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Component/s: XML
    • Labels:
      None
    • Number of attachments :
      5

      Description

      As preparation for the JAXB implementation of Castor we need to have an extendable ClassDescriptorResolver.

      The idea is to create one command for each resolve path currently implemented and then sum all commands up in a Castor XML strategy.

      1. castor-1932.txt
        111 kB
        Joachim Grüneis
      2. castor-1932-20070610.txt
        90 kB
        Joachim Grüneis
      3. castor-1932-20070701.txt
        97 kB
        Joachim Grüneis
      4. castor-1932-20070725.txt
        102 kB
        Joachim Grüneis
      5. patch-C1932-20070728.txt
        110 kB
        Ralf Joachim

        Activity

        Hide
        Joachim Grüneis added a comment -

        I've overworked the patch a lot... the 'main' changes are:
        *) introduced ResolverPackageCommand package are different then classes and with XMLClassDescriptorCacheImple.addPackage we have the need for pure package stuff
        *) I did it!! Now only the class name is required to be handed down to strategy and commands... the class loaders had been beasts but I've tamed them
        *) there are now abstract commands to ensure a maximum of NOT copied coded
        maybe I've missed something in my list... but I think these are the high lights.

        Show
        Joachim Grüneis added a comment - I've overworked the patch a lot... the 'main' changes are: *) introduced ResolverPackageCommand package are different then classes and with XMLClassDescriptorCacheImple.addPackage we have the need for pure package stuff *) I did it!! Now only the class name is required to be handed down to strategy and commands... the class loaders had been beasts but I've tamed them *) there are now abstract commands to ensure a maximum of NOT copied coded maybe I've missed something in my list... but I think these are the high lights.
        Hide
        Joachim Grüneis added a comment -

        As for configuration: this needs to change as soon as the new configuration stuff is available.

        Show
        Joachim Grüneis added a comment - As for configuration: this needs to change as soon as the new configuration stuff is available.
        Hide
        Ralf Joachim added a comment -

        Haven't had enough time to look at the new patch in more details but what I recognized are some warnings of ResolverException being not declared in ResolverCommands while it is declared to be thrown at one of the resolve methods. So I wonder if you intended it to be a checked or unchecked exception.

        Show
        Ralf Joachim added a comment - Haven't had enough time to look at the new patch in more details but what I recognized are some warnings of ResolverException being not declared in ResolverCommands while it is declared to be thrown at one of the resolve methods. So I wonder if you intended it to be a checked or unchecked exception.
        Hide
        Joachim Grüneis added a comment -

        Corrected problem with not declared exception.

        Show
        Joachim Grüneis added a comment - Corrected problem with not declared exception.
        Hide
        Ralf Joachim added a comment -

        Final patch with some minor changes at Joachim's original code.

        Show
        Ralf Joachim added a comment - Final patch with some minor changes at Joachim's original code.

          People

          • Assignee:
            Joachim Grüneis
            Reporter:
            Joachim Grüneis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: