[#CASTOR-1865] XML unmarshalling validation does not always check required flag - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.0.5
Fix Version/s: 1.1.1
Component/s: XML
Labels:
None
Environment:
Java 1.4.2

Testcase included:
yes
Number of attachments :
3

Description

The required flag is not always checked during unmarshalling.

In particular this issue contains a test case that fails when an element with a missing requried attribute is contained with a list, and has at least one attribute present.

The attached patch (against HEAD) fixes the issue for me, but I haven't run the full test suite because there don't appear to be any instructions on how to do so.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

CASTOR-1865.patch

12/Feb/07 6:33 AM

1 kB

Guy Coleman
patch.c1865.20070216.txt

16/Feb/07 12:34 PM

27 kB

Werner Guttmann
$i18n.getText("admin.common.words.hide")
testcase.zip

12/Feb/07 6:30 AM

3 kB

Guy Coleman
xml/bug1865/Dog.java 0.4 kB

xml/bug1865/dog1.xml 0.0 kB

xml/bug1865/dog2.xml 0.0 kB

xml/bug1865/Kennel.java 0.3 kB

xml/bug1865/kennel1.xml 0.1 kB

xml/bug1865/kennel2.xml 0.1 kB

xml/bug1865/mapping.xml 0.6 kB

xml/bug1865/README.txt 0.6 kB

xml/bug1865/TestRequired.java 2 kB

Download Zip
$i18n.getText("admin.common.words.show")

testcase.zip

12/Feb/07 6:30 AM

3 kB

Guy Coleman

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Guy Coleman added a comment - 12/Feb/07 6:30 AM

Test case that shows the bug

Show

Guy Coleman added a comment - 12/Feb/07 6:30 AM Test case that shows the bug

Hide

Permalink

Guy Coleman added a comment - 12/Feb/07 6:33 AM

Patch that solves the issue for me.

Show

Guy Coleman added a comment - 12/Feb/07 6:33 AM Patch that solves the issue for me.

Hide

Permalink

Werner Guttmann added a comment - 16/Feb/07 11:44 AM

http://castor.org/how-to-run-xml-ctf-suite.html should have the information required to run the CTF test suite. Looks like we have to cross-link things a bit more ....

Show

Werner Guttmann added a comment - 16/Feb/07 11:44 AM http://castor.org/how-to-run-xml-ctf-suite.html should have the information required to run the CTF test suite. Looks like we have to cross-link things a bit more ....

Hide

Permalink

Werner Guttmann added a comment - 16/Feb/07 12:14 PM

fwiw, CTF runs fine ....

Show

Werner Guttmann added a comment - 16/Feb/07 12:14 PM fwiw, CTF runs fine ....

Hide

Permalink

Werner Guttmann added a comment - 16/Feb/07 12:34 PM

Final patch for review (incl. new test cases for the CTF).

Show

Werner Guttmann added a comment - 16/Feb/07 12:34 PM Final patch for review (incl. new test cases for the CTF).

People

Assignee:

Werner Guttmann

Reporter:

Guy Coleman

Vote (0)

Watch (1)

Dates

Created:

12/Feb/07 6:18 AM

Updated:

20/Apr/07 10:23 AM

Resolved:

16/Feb/07 12:40 PM