castor

XSInt should not extend XSLong, but be mapped onto a Java 'int' type

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.1 M1
  • Fix Version/s: 1.1 M2
  • Component/s: XML code generator
  • Labels:
    None
  • Number of attachments :
    3
  1. File
    castor-1760-patch2.diff
    24/Dec/06 10:02 AM
    36 kB
    Edward Kuns
  2. Text File
    patch.c1760.20061224.txt
    23/Dec/06 6:14 PM
    31 kB
    Werner Guttmann
  3. Text File
    patch.c1760.20061225.txt
    25/Dec/06 6:45 AM
    31 kB
    Werner Guttmann

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CASTOR-1759 XSUnsignedShort should extend XSInt (rather than XSInteger)

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

A revert to an older version might actually do the trick, as XSInt once upon a long time used to map its JType onto 'java.lang.Integer'/int.

Show
Werner Guttmann added a comment - A revert to an older version might actually do the trick, as XSInt once upon a long time used to map its JType onto 'java.lang.Integer'/int.
Hide
Permalink
Werner Guttmann added a comment -

Patch for review, fixing both CASTOR-1760 and CASTOR-1759. There's one facet test that seems to fail .....

Show
Werner Guttmann added a comment - Patch for review, fixing both CASTOR-1760 and CASTOR-1759 . There's one facet test that seems to fail .... .
Hide
Permalink
Edward Kuns added a comment -

I had to apply part of your patch by hand, but I get no failures. I tried under both JDK5 and 1.4.2 and all tests pass either way.

Attached is an updated patch against current trunk.

Don't forget that there will also be changed in JDO for this change – I remember seeing those changes the last time.

Show
Edward Kuns added a comment - I had to apply part of your patch by hand, but I get no failures. I tried under both JDK5 and 1.4.2 and all tests pass either way. Attached is an updated patch against current trunk. Don't forget that there will also be changed in JDO for this change – I remember seeing those changes the last time.
Hide
Permalink
Werner Guttmann added a comment -

Same here .. . Looks like your patch as submitted as part of CASTOR-1761 made the problems go away. Lucky us. Btw, the JDO classes do not have to be changed, as we are changing <xsd:int> only, as mapping.xsd does use <xsd:integer> only .. .

Show
Werner Guttmann added a comment - Same here .. . Looks like your patch as submitted as part of CASTOR-1761 made the problems go away. Lucky us. Btw, the JDO classes do not have to be changed, as we are changing <xsd:int> only, as mapping.xsd does use <xsd:integer> only .. .
Hide
Permalink
Werner Guttmann added a comment -

Final patch for review.

Show
Werner Guttmann added a comment - Final patch for review.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Werner Guttmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1h
Original Estimate - 1 hour
Remaining:
1h
Remaining Estimate - 1 hour
Logged:
Not Specified
Time Spent - Not Specified