castor

Code Generator - compile errors - missing types and casting exceptions

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.1 M1
  • Fix Version/s: 1.3.4
  • Component/s: XML code generator
  • Labels:
    None
  • Environment:
    suse 10.1
    eclipse 3.2
    java 1.5
  • Number of attachments :
    6

Description

With the resolution of CASTOR-1659 new compile errors are being generated from the attached xsd files.

I checked out the latest from the svn this morning.

I am still working on the same set of xsd files as in CASTOR-1710 and CASTOR-1717.

There seems to be missing a types attribute and a large number of casting exceptions generally around the class TEXTTYPE.

These two must be generated together or a large number of errors are created from missing class definitions.

The full generation of the entire schema throws 741 compile errors but the sample of errors generated from these two xsd files shows most of the errors.

Sorry guys, I don't really have a good idea on whats going on with this set of errors.

Thanks
Quince

  1. XML File
    jxdm.xsd
    11/Dec/06 11:14 AM
    2.69 MB
    Quince D. Wilson
  3. Text File
    patch_C1729_20070306.txt
    06/Mar/07 2:46 PM
    5 kB
    Steven Dolg
  4. Java Source File
    TestGen1.java
    12/Dec/06 7:37 AM
    7 kB
    Quince D. Wilson
  6. XML File
    xsd.xsd
    11/Dec/06 11:14 AM
    9 kB
    Quince D. Wilson

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Quince, are these new compilation errors a result of fixing CASTOR-1659, or have you never been able to get this far ?

Show
Werner Guttmann added a comment - Quince, are these new compilation errors a result of fixing CASTOR-1659 , or have you never been able to get this far ?
Hide
Permalink
Quince D. Wilson added a comment -

Werner,

Back on version 1.0.2 the only problem was CASTOR-1710 - static initializer. When I moved up to 1.0.5 I was getting CASTOR-1659.

So I guess the direct answer is I have not been able to get this far. I think CASTOR-1659 was stopping these from appearing. These errors are more in line with CASTOR-1717 but that is only a guess.

Thanks
Quince

Show
Quince D. Wilson added a comment - Werner, Back on version 1.0.2 the only problem was CASTOR-1710 - static initializer. When I moved up to 1.0.5 I was getting CASTOR-1659 . So I guess the direct answer is I have not been able to get this far. I think CASTOR-1659 was stopping these from appearing. These errors are more in line with CASTOR-1717 but that is only a guess. Thanks Quince
Hide
Permalink
Werner Guttmann added a comment -

Okay, I'll have a look later on today. In general, it would be great if you could isolate a problem and provide me with a trimmed down XML schema, as debugging/analysing such big schemas never is easy ....

Show
Werner Guttmann added a comment - Okay, I'll have a look later on today. In general, it would be great if you could isolate a problem and provide me with a trimmed down XML schema, as debugging/analysing such big schemas never is easy ....
Hide
Permalink
Werner Guttmann added a comment -

Let me just repeat that: the jxdm schema has way too many dependencies to be used in a meaningful way, and I don't want to be responsible to building an environment where I can run the source generator successfully. Can you please either trim down the XML schema(s) involved, or present me with a complete set of files where all dependencies are resolved ? Thanks in advance ...

Show
Werner Guttmann added a comment - Let me just repeat that: the jxdm schema has way too many dependencies to be used in a meaningful way, and I don't want to be responsible to building an environment where I can run the source generator successfully. Can you please either trim down the XML schema(s) involved, or present me with a complete set of files where all dependencies are resolved ? Thanks in advance ...
Hide
Permalink
Quince D. Wilson added a comment -

Werner,

Attached is a complete set of xsd files.

Also, when I created CASTOR-1710 I attached and eclipse environment with the complete set of files and with a TestGen1 class for generating all the necessary classes.

I have tried to trim it down to a better test case but ran into to may dependancy issues. Using the two attached xsd files with the case does not cause any dependancy issues that I could see, only the compile issues. These two files create by themselves, all the errors. Eclipse does not want to show me all the errors even though I have increased the max number for the project and the workspace but the number of errors match exactly.

Thanks
Quince

Show
Quince D. Wilson added a comment - Werner, Attached is a complete set of xsd files. Also, when I created CASTOR-1710 I attached and eclipse environment with the complete set of files and with a TestGen1 class for generating all the necessary classes. I have tried to trim it down to a better test case but ran into to may dependancy issues. Using the two attached xsd files with the case does not cause any dependancy issues that I could see, only the compile issues. These two files create by themselves, all the errors. Eclipse does not want to show me all the errors even though I have increased the max number for the project and the workspace but the number of errors match exactly. Thanks Quince
Hide
Permalink
Werner Guttmann added a comment -

It's funny, Eclipse crashes on me however much memory I assign to it .. ;-(.

Show
Werner Guttmann added a comment - It's funny, Eclipse crashes on me however much memory I assign to it .. ;-(.
Hide
Permalink
Werner Guttmann added a comment -

That class TestGen1 is not attached any more to CASTOR-1710 (as I might have deleted it). Anyhow, when you generate the sources, are you setting setGenerateImportedSchemas() to true ?

Show
Werner Guttmann added a comment - That class TestGen1 is not attached any more to CASTOR-1710 (as I might have deleted it). Anyhow, when you generate the sources, are you setting setGenerateImportedSchemas() to true ?
Hide
Permalink
Werner Guttmann added a comment -

Okay, some random observations (from the limited set of generated classes, before my JVM dies):

Class: VictimOffenseChargeText.java
has
public static xml.c1729.generated.TextType unmarshal(java.io.Reader reader)

extends: TextType.java
has:
public static xml.c1729.generated.TextType unmarshal(java.io.Reader reader)

extends: String.java (not java.util.String)
has:
public static xml.c1729.generated.String unmarshal(java.io.Reader reader)

Apparently, that's wrong, as both VictimOffenseChargeText.unmarshal() and TextType.unmarshal() should return xml.c1729.generated.String, and not xml.c1729.generated.TextType.

Show
Werner Guttmann added a comment - Okay, some random observations (from the limited set of generated classes, before my JVM dies): Class: VictimOffenseChargeText.java has public static xml.c1729.generated.TextType unmarshal(java.io.Reader reader) extends: TextType.java has: public static xml.c1729.generated.TextType unmarshal(java.io.Reader reader) extends: String.java (not java.util.String) has: public static xml.c1729.generated.String unmarshal(java.io.Reader reader) Apparently, that's wrong, as both VictimOffenseChargeText.unmarshal() and TextType.unmarshal() should return xml.c1729.generated.String, and not xml.c1729.generated.TextType.
Hide
Permalink
Quince D. Wilson added a comment -

Werner,

Attached is the TestGen1 class I have been using. This should answer your questions. Let me know if I should add the parameter you mentioned.

Also, I was having the same problem with eclipse crashing, come to find out, I had some bad memory modules. I had to let the memory test run all night before it would identify a problem, of course by that time I had reformatted my drives and everything else.

Thanks
Quince

Show
Quince D. Wilson added a comment - Werner, Attached is the TestGen1 class I have been using. This should answer your questions. Let me know if I should add the parameter you mentioned. Also, I was having the same problem with eclipse crashing, come to find out, I had some bad memory modules. I had to let the memory test run all night before it would identify a problem, of course by that time I had reformatted my drives and everything else. Thanks Quince
Hide
Permalink
Steven Dolg added a comment -

The problem with the wrong method signature is a result of generating the schemas individually.
That way the inheritance across multiple schemas is not generated correctly.

This can be corrected by using the "-generateImportedSchemas" option and only calling the SourceGenerator for the top schema (in this case "jxdm/3.0.3/jxdm.xsd").

However currently this will result in some other problems:

  • Inheritance is still broken
  • Package names are not used correctly.

I attached a patch that fixes both problems.

Show
Steven Dolg added a comment - The problem with the wrong method signature is a result of generating the schemas individually. That way the inheritance across multiple schemas is not generated correctly. This can be corrected by using the "-generateImportedSchemas" option and only calling the SourceGenerator for the top schema (in this case "jxdm/3.0.3/jxdm.xsd"). However currently this will result in some other problems: Inheritance is still broken Package names are not used correctly. I attached a patch that fixes both problems.
Hide
Permalink
Steven Dolg added a comment -

This is a test case that uses the Source Generator in the way described above.
On my machine this succesfully generates compileable code. (Although there are 6 name conflicts).

WARNING: If you execute this test case the Source Generator will create more than 10,000 files.
This is likely going to take 5 minutes or more and use approximately 500MB of RAM.

When compile this with Eclipse (and probably with other IDEs as well) this is going to take very long.
Also your disk is going to be stressed enormously. (I used a RAM disk to speed up things...)

Show
Steven Dolg added a comment - This is a test case that uses the Source Generator in the way described above. On my machine this succesfully generates compileable code. (Although there are 6 name conflicts). WARNING: If you execute this test case the Source Generator will create more than 10,000 files. This is likely going to take 5 minutes or more and use approximately 500MB of RAM. When compile this with Eclipse (and probably with other IDEs as well) this is going to take very long. Also your disk is going to be stressed enormously. (I used a RAM disk to speed up things...)
Hide
Permalink
Werner Guttmann added a comment -

Steven, would it be possible for you to come up with a minimal test case that we could integrate into the CTF suite ?

Show
Werner Guttmann added a comment - Steven, would it be possible for you to come up with a minimal test case that we could integrate into the CTF suite ?

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Quince D. Wilson
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: