castor

Add support for validating <xsd:ID> types elements/attributes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.5
  • Fix Version/s: 1.1 M1
  • Component/s: XML code generator
  • Labels:
    None
  • Number of attachments :
    2

Description

Currently, the Castor XML code generator does not create any special validation logic for <xsd:ID> typed elements/attributes. As a result, it is currently impossible to assess that ...

a) a content element typed with <xsd:ID> is not empty.
b) there's more than one such content element with an identical value.

The idea is to create a new IdValidator and modify the XML code generator to make sure that this new validator is called accordingly.

  1. File
    patch.c1720.20061206.diff
    06/Dec/06 1:53 PM
    11 kB
    Werner Guttmann
  2. Text File
    patch.c1720.20061206.tests.txt
    06/Dec/06 3:09 PM
    16 kB
    Werner Guttmann

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. CASTOR-1722 Add support for validating <xsd:IDREF> types elements/attributes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Initial patch for review.

Show
Werner Guttmann added a comment - Initial patch for review.
Hide
Permalink
Werner Guttmann added a comment -

The idea now is to add test case after test case to check various scenarios, and to validate the taken approach.

Show
Werner Guttmann added a comment - The idea now is to add test case after test case to check various scenarios, and to validate the taken approach.
Hide
Permalink
Edward Kuns added a comment -

Looks OK to me. Although on the new class you added, don't you want to put yourself as the author and change the copyright notice?

Show
Edward Kuns added a comment - Looks OK to me. Although on the new class you added, don't you want to put yourself as the author and change the copyright notice?
Hide
Permalink
Werner Guttmann added a comment -

Most definitely. I guess I will even move the new classes (and those largely refactored to the org.castor package). Thanks for reminding me .... .

Show
Werner Guttmann added a comment - Most definitely. I guess I will even move the new classes (and those largely refactored to the org.castor package). Thanks for reminding me .... .
Hide
Permalink
Werner Guttmann added a comment -

As a reminder to myself, so far validation during unmarshalling has been looked at. And adding - possibly maybe - life-cycle methods might become an issue as well.

Show
Werner Guttmann added a comment - As a reminder to myself, so far validation during unmarshalling has been looked at. And adding - possibly maybe - life-cycle methods might become an issue as well.
Hide
Permalink
Werner Guttmann added a comment -

JUnit tests relative to src/bugs.

Show
Werner Guttmann added a comment - JUnit tests relative to src/bugs.
Hide
Permalink
Werner Guttmann added a comment -

A little change: through this issue, only validation during marshalling should be addressed. Castor's Unmarshaller has already support for an IDResolver, which just needs to be expanded to deal with empty and duplicate IDs. This will be addressed through a separate Jira issue.

Show
Werner Guttmann added a comment - A little change: through this issue, only validation during marshalling should be addressed. Castor's Unmarshaller has already support for an IDResolver, which just needs to be expanded to deal with empty and duplicate IDs. This will be addressed through a separate Jira issue.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Werner Guttmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
5d 1h 30m
Original Estimate - 5 days, 1 hour, 30 minutes
Remaining:
5d 1h 30m
Remaining Estimate - 5 days, 1 hour, 30 minutes
Logged:
Not Specified
Time Spent - Not Specified