castor
  1. castor
  2. CASTOR-1695

It's impossible to control options -generateImportedSchemas and -f from ANT task org.exolab.castor.tools.ant.taskdefs.CastorSourceGenTask

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.5
    • Fix Version/s: 1.1 M1
    • Component/s: XML code generator
    • Labels:
      None
    • Number of attachments :
      1

      Description

      I propose a simple patch for org.exolab.castor.tools.ant.taskdefs.CastorSourceGenTask:

      private boolean generateImportedSchemas;
      public void setGenerateImportedSchemas(boolean generateImportedSchemas) {
      this.generateImportedSchemas = generateImportedSchemas;
      }
      // and
      private void config() throws BuildException {
      ...
      sgen.setGenerateImportedSchemas(generateImportedSchemas);
      ...
      }

      // the same for -f option

        Activity

        Hide
        Werner Guttmann added a comment -

        Vasily, can you please attach your proposed patch in form of a unified patch (to ease our life) ?

        Show
        Werner Guttmann added a comment - Vasily, can you please attach your proposed patch in form of a unified patch (to ease our life) ?
        Hide
        Werner Guttmann added a comment -

        Actually, just did it myself .... and the -f option in actually already configurable via the 'warnings' property.

        Show
        Werner Guttmann added a comment - Actually, just did it myself .... and the -f option in actually already configurable via the 'warnings' property.
        Hide
        Werner Guttmann added a comment -

        Final patch for review.

        Show
        Werner Guttmann added a comment - Final patch for review.
        Hide
        Werner Guttmann added a comment -

        Patch committed as is ....

        Show
        Werner Guttmann added a comment - Patch committed as is ....
        Hide
        Vasily Lazerko added a comment -

        Thanks, Werner.
        For full compatibility with command line invocation method options -sax1 and -case-insensitive are also missing.
        But it is not critical for the moment.

        Show
        Vasily Lazerko added a comment - Thanks, Werner. For full compatibility with command line invocation method options -sax1 and -case-insensitive are also missing. But it is not critical for the moment.
        Hide
        Werner Guttmann added a comment -

        No problem, I will take care of those.

        Show
        Werner Guttmann added a comment - No problem, I will take care of those.

          People

          • Assignee:
            Werner Guttmann
            Reporter:
            Vasily Lazerko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 15 minutes
              15m