castor
  1. castor
  2. CASTOR-1691

Implement a way to allow Castor to report un/marshaling exceptions

    Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0.5, 1.1, 1.1.1, 1.1.2, 1.1.2.1, 1.2
    • Fix Version/s: 1.3.4
    • Component/s: XML
    • Labels:
      None
    • Number of attachments :
      3

      Description

      Currently, when an exception occurs during marshaling or unmarshaling, the exception is logged and ignored.
      This Jira issue will address this issue. Subtasks will be created to handle specific implementation steps.

      1. jira-1691-patch.txt
        16 kB
        Paul Philion
      2. patch.c1691.20061117.txt
        4 kB
        Werner Guttmann
      3. patch.c1691.20080602.txt
        15 kB
        Werner Guttmann

        Issue Links

          Activity

          Hide
          Werner Guttmann added a comment -

          I think that - as a first step - we should try to move current exception handling into a new (to be created) strategy implementation, but leave current functionality as is. Any objections ?

          Show
          Werner Guttmann added a comment - I think that - as a first step - we should try to move current exception handling into a new (to be created) strategy implementation, but leave current functionality as is. Any objections ?
          Hide
          Ralf Joachim added a comment -

          Sounds like a good idea.

          Show
          Ralf Joachim added a comment - Sounds like a good idea.
          Hide
          Werner Guttmann added a comment -

          Initial (very sketchy) draft of an idea ... .

          Show
          Werner Guttmann added a comment - Initial (very sketchy) draft of an idea ... .
          Hide
          Edward Kuns added a comment -

          +1

          Show
          Edward Kuns added a comment - +1
          Hide
          Paul Philion added a comment -

          +1

          And I've got some time to work on it.

          Werner, have you started any work in this direction? If not, I am happy to start adapting the Marshaller to this.

          Show
          Paul Philion added a comment - +1 And I've got some time to work on it. Werner, have you started any work in this direction? If not, I am happy to start adapting the Marshaller to this.
          Hide
          Werner Guttmann added a comment -

          No, I have not. As already mentioned, moving the current exception handling into a strategy should be possible (and useful). Once that has been done, adding a new strategy that goes about exception handling in a different way should be .. well, straight-forward.

          Show
          Werner Guttmann added a comment - No, I have not. As already mentioned, moving the current exception handling into a strategy should be possible (and useful). Once that has been done, adding a new strategy that goes about exception handling in a different way should be .. well, straight-forward.
          Hide
          Paul Philion added a comment -

          I will start bringing the ErrorHandler into both the Marshaller and Unmarshaller.

          Show
          Paul Philion added a comment - I will start bringing the ErrorHandler into both the Marshaller and Unmarshaller.
          Hide
          Edward Kuns added a comment -

          Most Excellent!

          Show
          Edward Kuns added a comment - Most Excellent!
          Hide
          Paul Philion added a comment -

          Werner: When do you plan to put together the release for 1.1.2? I want to make sure to have this patch ready (including docs, test cases, etc.) before then.

          Show
          Paul Philion added a comment - Werner: When do you plan to put together the release for 1.1.2? I want to make sure to have this patch ready (including docs, test cases, etc.) before then.
          Hide
          Werner Guttmann added a comment -

          In a few weeks time, I suppose ..... no target date set yet, but given the high number of patches being committed right now (with loads of people switching to 1.1(.1) eventually), it feels like that increasing stability should be passed to our users.

          Show
          Werner Guttmann added a comment - In a few weeks time, I suppose ..... no target date set yet, but given the high number of patches being committed right now (with loads of people switching to 1.1(.1) eventually), it feels like that increasing stability should be passed to our users.
          Hide
          Paul Philion added a comment -

          Unified patch provides new interface for ErrorHandler, default implementations, test cases and documentation. Also include modification to Marshaller to use ErrorHandler.

          Show
          Paul Philion added a comment - Unified patch provides new interface for ErrorHandler, default implementations, test cases and documentation. Also include modification to Marshaller to use ErrorHandler.
          Hide
          Paul Philion added a comment -

          Arg... I don't recommend Eclipse for generating patch file, this gave me a lot of problems. svn diff on the command line works just fine, though.

          Show
          Paul Philion added a comment - Arg... I don't recommend Eclipse for generating patch file, this gave me a lot of problems. svn diff on the command line works just fine, though.
          Hide
          Werner Guttmann added a comment -

          Thanks, Paul. I will review your patch in due time. Can I ask you one favour, though. For each new patch that covers a more or less complete set of functionality (such as this patch does), can you please create individual sub-tasks in the future. This would ease our life considerably and allow us more fine-grain control.

          Show
          Werner Guttmann added a comment - Thanks, Paul. I will review your patch in due time. Can I ask you one favour, though. For each new patch that covers a more or less complete set of functionality (such as this patch does), can you please create individual sub-tasks in the future. This would ease our life considerably and allow us more fine-grain control.
          Hide
          Paul Philion added a comment -

          Werner,

          What subtasks would you expect? code/test/docs? ErrorHandler/Marshaller+test/docs?

          I am happy to refactor.

          Show
          Paul Philion added a comment - Werner, What subtasks would you expect? code/test/docs? ErrorHandler/Marshaller+test/docs? I am happy to refactor.
          Hide
          Werner Guttmann added a comment -

          Oops, sorry for the misunderstanding. I didn't mean to suggest and new and fancy re-packaging. I was eager to see any patch you attach (that represents a sizeable chunk) to be put into a new and separate sub-task. In other words, the patch you attached yesterday should go into its own sub-task, nothing more or less.

          Show
          Werner Guttmann added a comment - Oops, sorry for the misunderstanding. I didn't mean to suggest and new and fancy re-packaging. I was eager to see any patch you attach (that represents a sizeable chunk) to be put into a new and separate sub-task. In other words, the patch you attached yesterday should go into its own sub-task, nothing more or less.
          Hide
          Werner Guttmann added a comment -

          Updated patch, so that it can applied against SVN trunk again.

          • Reworked the interface.
          • Refactored some (minor) code areas.

          Any comments appreciated.

          Show
          Werner Guttmann added a comment - Updated patch, so that it can applied against SVN trunk again. Reworked the interface. Refactored some (minor) code areas. Any comments appreciated.

            People

            • Assignee:
              Werner Guttmann
              Reporter:
              Edward Kuns
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: