castor

Incorrect constants in AbstractMappingLoader

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.4
  • Fix Version/s: 1.0.5
  • Component/s: XML
  • Labels:
    None
  • Number of attachments :
    1

Description

To cut a long story short. Version 1.0.4 introduced some new private final fields in o.e.c.mapping.loader.AbstractMappingLoader. Three of them, namely CREATE_METHOD_PREFIX, HAS_METHOD_PREFIX and DELETE_METHOD_PREFIX, have incorrect values: "set" instead of "create", "has" and "delete" respectively.

Issue Links

relates to

Sub-task - The sub-task of the issue CASTOR-1584 Refactor AbstractMappingLoader

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ralf Joachim added a comment -

Definitly a copy and paste problem but I realy wonder how this could pass or test suite.

Show
Ralf Joachim added a comment - Definitly a copy and paste problem but I realy wonder how this could pass or test suite.
Hide
Permalink
Werner Guttmann added a comment -

And what's the long story, iima ? This is not just for fun, but an attempt to understand what damage this might have potentially caused.

Show
Werner Guttmann added a comment - And what's the long story, iima ? This is not just for fun, but an attempt to understand what damage this might have potentially caused.
Hide
Permalink
Pawel Pesz added a comment -

No damage was caused: just some of my queries stopped working. I was refering to the time it took me to analyze the code in search of the bug

Show
Pawel Pesz added a comment - No damage was caused: just some of my queries stopped working. I was refering to the time it took me to analyze the code in search of the bug
Hide
Permalink
Werner Guttmann added a comment -

I guess I'd call this damage enough .. . Ralf, shall we skip 1.0.5 rather soon .. and move the majority of the issues to either 1.0.6 or 1.1 (preferably). ?

Show
Werner Guttmann added a comment - I guess I'd call this damage enough .. . Ralf, shall we skip 1.0.5 rather soon .. and move the majority of the issues to either 1.0.6 or 1.1 (preferably). ?
Hide
Permalink
Werner Guttmann added a comment -

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Show
Werner Guttmann added a comment - Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Pawel Pesz
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: