CLONE -Missing methods in generated class

Hi Werner,

I saw your comments on my original ticket (CASTOR-1167) that you were able to compile without compilation errors. I have again tried to compile (using 1.0.4), but I still don't have the getter and setter methods for the choices in the generated class (WebServiceMonitor). When you did your compilation, did you see those methods?

I couldn't reopen the original ticket since it had been closed, so I opened a clone. I hope that was acceptable.

Susan

Susan,

can you please attach a valid XML document for sentry.xsd as Werner requested at CASTOR-1167. For anything else let's wait until Werner is back next week.

Ralf

As 1.0.4 is already released it can not be fixed with that one.

Susan, I just generated the classes once again, and I can confirm that the getter/setter for the choice in Web-service-monitor is not generated. In addition, I think you should change your XML schema in some way to (potentially) avoid naming collisions.

Re: the choice issue, I will have a look at this later on ....

Okay, the problem is with XMLInfo.getNodeName() in that for a choice element, this will return the string "error-if-this-is-used" (as set on line 400 of MemberFactory.java). Apparently, this problem does not manifest itself frequently .. , only when a type and its parent type both have a anonymous choice declaration as part of their content model. In this case, as both use 'error-if-this-is-used' as node names, for the latter one (at run-time), no Java field (and corresponding access methods) will be generated, as the code generator believes that for this node (as identified by its node name) code has already been generated.

Well, this is the problem analysis. We now have to find a way to replace 'error-if-this-is-used' with something more meaningful. Any ideas ?

I think I have just come to realize that there's a 'quick win' solution. I will provide a patch in a few minutes (after some more testing, that is).

Initial patch for review. Any comments appreciated .. . I have added a few more web-service-monitor instances to the XML instance document to test a few more cases, and as it is right now, it should fail (as the last web-service-monitor is not valid). When commenting out the last one, everything just runs fine.

Susan, for the time being, I am basically asking my peer committers for feedback. Once this has been reviewed, I will integrate this into the code base and provide you with a snapshot release for further testing, if that's okay with you. Please feel free to join me at http://irc.codehaus.org, channel #castor if you happen to have any questions.

Committing as is, after adding a new CTF test to the master test suite. Susan, I will make available a snapshot release for 1.0.5 within 24 hours for you to use for testing.

Susan, a snapshot release is available at http://snapshots.repository.codehaus.org/org/codehaus/castor/castor/1.0.5-SNAPSHOT/ as explained in my announcement a few minutes ago. I'd appreciate any feedback (within 24 hours), if possible.

In addition, how would you feel if I asked you for your permission to make it known to our users that you (IBM) is using Castor XML for internal product development (my assumption .. ), let's say on a user experience page (sort of stepping up marketing for Castor to some degree now that quality is returning to standard) ?

Hi Werner,

I downloaded the snapshot and compiled my code. It worked! I still have other issues that I need to work on (I may not have all the other pieces that I need to interface with castor in our environment), but I can compile.

I will ask about using our name on your user page. My group is using castor for the Qwest account; I don't know if other IBM teams are using it. We were with Qwest before being outsourced to IBM – I'm sure you know how that goes.

Thanks so much for working on this for me.

Thanks, Susan, for the feedback. Really appreciated. I look forward to hear from you wrt to using IBM's name on our user page, and feel free to open new issues when ever required.

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Hi Werner,

My lead thinks there is no problem using our name on your user page. It is technically Qwest that is using Castor since the code we support is Qwest-proprietary, but we do work for IBM.

Thanks for all the help on this problem.

Susan

In that case, can you provide me with a short description of IBM (contextualized), and the apparent use case. I'll have to make up my mind where to put this in the end, but I will follow up in due time.