castor

Use java.util.List as signature type for Java 2 collections

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4
  • Fix Version/s: 1.0.5
  • Component/s: XML code generator
  • Labels:
    None
  • Number of attachments :
    2

Description

When generating fields/methods in Java 2 mode, Source Generator uses ArrayLists as a drop-in
replacement for Vectors. This overlooks the flexibility possible with Java 2 collections. It would be
better to use parameters/return values of type List so that code that uses the generated object
model are not forced to convert to/from ArrayLists.

  1. Text File
    patch.c1677.20061102.txt
    02/Nov/06 5:10 PM
    8 kB
    Werner Guttmann
  2. Text File
    patch.c1677.20061102-002.txt
    02/Nov/06 5:18 PM
    7 kB
    Werner Guttmann

Activity

Ascending order - Click to sort in descending order
Werner Guttmann made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Werner Guttmann made changes -
Status In Progress [ 3 ] Open [ 1 ]
Hide
Permalink
Werner Guttmann added a comment -

Initial patch for review, basically amending a few classes related to how the code generator handles collections to support distinction between collection interface signatures and collection instantiation.

Show
Werner Guttmann added a comment - Initial patch for review, basically amending a few classes related to how the code generator handles collections to support distinction between collection interface signatures and collection instantiation.
Werner Guttmann made changes -
Attachment patch.c1677.20061102.txt [ 23795 ]
Hide
Permalink
Werner Guttmann added a comment -

Updated patch, re-adding the original constructor to JCollectionType, and reverting some of the other changes, as getInstanceName() now checks whether _instancename is not null, otherwise delegating to toString().

Show
Werner Guttmann added a comment - Updated patch, re-adding the original constructor to JCollectionType, and reverting some of the other changes, as getInstanceName() now checks whether _instancename is not null, otherwise delegating to toString().
Werner Guttmann made changes -
Attachment patch.c1677.20061102-002.txt [ 23796 ]
Permalink
Werner Guttmann logged work - 02/Nov/06 5:20 PM
  • Time Spent:
    45 minutes
     
    Patch creation & testing.
Werner Guttmann made changes -
Time Spent 45 minutes [ 2700 ]
Remaining Estimate 1 hour, 30 minutes [ 5400 ] 45 minutes [ 2700 ]
Hide
Permalink
Werner Guttmann added a comment -

Just as a note for myself, one could now extend the binding file syntax to allow definition of the actual collection instance type.

Show
Werner Guttmann added a comment - Just as a note for myself, one could now extend the binding file syntax to allow definition of the actual collection instance type.
Werner Guttmann made changes -
Fix Version/s 1.0.5 [ 12953 ]
Hide
Permalink
Werner Guttmann added a comment -

Need to make it really clear in the release notes that this is happening, and scan all samples for usage of java.util.ArrayList as well.

Show
Werner Guttmann added a comment - Need to make it really clear in the release notes that this is happening, and scan all samples for usage of java.util.ArrayList as well.
Hide
Permalink
Edward Kuns added a comment -

I definitely like the idea of using a truer J2 collection. Patch looks reasonable to me.

Show
Edward Kuns added a comment - I definitely like the idea of using a truer J2 collection. Patch looks reasonable to me.
Werner Guttmann made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Permalink
Werner Guttmann logged work - 08/Nov/06 2:13 PM
  • Time Spent:
    15 minutes
     
    CTF test addition & release notes.
Werner Guttmann made changes -
Time Spent 45 minutes [ 2700 ] 1 hour [ 3600 ]
Remaining Estimate 45 minutes [ 2700 ] 30 minutes [ 1800 ]
Hide
Permalink
Werner Guttmann added a comment -

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Show
Werner Guttmann added a comment - Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.
Werner Guttmann made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Werner Guttmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1h 30m
Original Estimate - 1 hour, 30 minutes
Remaining:
30m
Time Spent - 1 hour Remaining Estimate - 30 minutes
Logged:
1h
Time Spent - 1 hour Remaining Estimate - 30 minutes