castor

SchemaWriter not serializing anyAttribute child of a complexType

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.4
  • Fix Version/s: 1.0.5
  • Component/s: XML code generator
  • Labels:
    None
  • Environment:
    Any
  • Number of attachments :
    4

Description

When serializing a schema using hte SchemaWriter, the anyAttribute child of a complexType (if any) does not get serialized.

To reproduce, simply create an XSD file that uses <anyAttribute>, deserialize into a Schema object, then serialize using SchemaWriter.

  1. Java Source File
    CastorAnyAttributeTest14.java
    02/Nov/06 8:11 AM
    3 kB
    Eric Wittmann
  2. Text File
    patch.c1675.20061102.txt
    02/Nov/06 8:41 AM
    0.6 kB
    Werner Guttmann
  3. Text File
    patch.c1675.sample.20061102.txt
    02/Nov/06 8:46 AM
    3 kB
    Werner Guttmann
  4. Text File
    SchemaWriter.patch
    01/Nov/06 11:28 AM
    0.2 kB
    Eric Wittmann

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Eric, would you mind attaching a fully working (JUnit) test case to reproduce this problem. I know I could do this myself, but I hope you do understand that this gets tedious with an increasing number of bug reports .. .

Show
Werner Guttmann added a comment - Eric, would you mind attaching a fully working (JUnit) test case to reproduce this problem. I know I could do this myself, but I hope you do understand that this gets tedious with an increasing number of bug reports .. .
Hide
Permalink
Eric Wittmann added a comment -

A unit test for anyAttribute serialization.

Show
Eric Wittmann added a comment - A unit test for anyAttribute serialization.
Eric Wittmann made changes -
Field Original Value New Value
Attachment CastorAnyAttributeTest.java [ 23779 ]
Hide
Permalink
Eric Wittmann added a comment -

I have attached a new version of the unit test that works with Castor 1.4. I wrote the previous unit test attachment against an older version of Castor, my apologies. This latest unit test will fail when run against Castor 1.4.

Also note that my patch may be a bit off if applied to Castor 1.4 source. But it's simple enough that I'm sure whoever is applying it will figure it out.

Show
Eric Wittmann added a comment - I have attached a new version of the unit test that works with Castor 1.4. I wrote the previous unit test attachment against an older version of Castor, my apologies. This latest unit test will fail when run against Castor 1.4. Also note that my patch may be a bit off if applied to Castor 1.4 source. But it's simple enough that I'm sure whoever is applying it will figure it out.
Eric Wittmann made changes -
Attachment CastorAnyAttributeTest14.java [ 23780 ]
Hide
Permalink
Werner Guttmann added a comment -

Eric, on line 70 of your test case, you are using the method getComplexType(String, String) on Schema. Apparently, that is a method that does not exist on the Schema class (in SVN trunk).

Show
Werner Guttmann added a comment - Eric, on line 70 of your test case, you are using the method getComplexType(String, String) on Schema. Apparently, that is a method that does not exist on the Schema class (in SVN trunk).
Hide
Permalink
Eric Wittmann added a comment -

You are right.

See my addendum comment: http://jira.codehaus.org/browse/CASTOR-1675#action_79101

I attached a new unit test with the corrections.

Is there a way to remove attachments?

Show
Eric Wittmann added a comment - You are right. See my addendum comment: http://jira.codehaus.org/browse/CASTOR-1675#action_79101 I attached a new unit test with the corrections. Is there a way to remove attachments?
Werner Guttmann made changes -
Assignee Werner Guttmann [ wguttmn ]
Werner Guttmann made changes -
Fix Version/s 1.0.5 [ 12953 ]
Component/s General [ 11502 ]
Component/s XML source generator [ 11761 ]
Remaining Estimate 30 minutes [ 1800 ]
Original Estimate 30 minutes [ 1800 ]
Hide
Permalink
Werner Guttmann added a comment -

Final patch. All tests still execute w/o problems .. . I cannot see a valid way how to add the test case provided to the CTF suite ... .

Show
Werner Guttmann added a comment - Final patch. All tests still execute w/o problems .. . I cannot see a valid way how to add the test case provided to the CTF suite ... .
Werner Guttmann made changes -
Attachment patch.c1675.20061102.txt [ 23781 ]
Werner Guttmann made changes -
Attachment CastorAnyAttributeTest.java [ 23779 ]
Hide
Permalink
Werner Guttmann added a comment -

JUnit test case (for historic reasons), relative to src/bugs.

Show
Werner Guttmann added a comment - JUnit test case (for historic reasons), relative to src/bugs.
Werner Guttmann made changes -
Attachment patch.c1675.sample.20061102.txt [ 23782 ]
Hide
Permalink
Werner Guttmann added a comment -

Patch committed as is ...

Show
Werner Guttmann added a comment - Patch committed as is ...
Werner Guttmann made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Permalink
Werner Guttmann logged work - 02/Nov/06 8:47 AM
  • Time Spent:
    20 minutes
     
    Patch integration.
Werner Guttmann made changes -
Remaining Estimate 30 minutes [ 1800 ] 10 minutes [ 600 ]
Time Spent 20 minutes [ 1200 ]
Hide
Permalink
Edward Kuns added a comment -

Should the test case be added to SVN?

Show
Edward Kuns added a comment - Should the test case be added to SVN?
Hide
Permalink
Werner Guttmann added a comment -

I guess it won't be easily addable, as it tests the SchemaWriter in addition to SchemaReader .. . Iow, I'd love to, but don't see a way how.

Show
Werner Guttmann added a comment - I guess it won't be easily addable, as it tests the SchemaWriter in addition to SchemaReader .. . Iow, I'd love to, but don't see a way how.
Hide
Permalink
Werner Guttmann added a comment -

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Show
Werner Guttmann added a comment - Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.
Werner Guttmann made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Eric Wittmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
30m
Original Estimate - 30 minutes
Remaining:
10m
Time Spent - 20 minutes Remaining Estimate - 10 minutes
Logged:
20m
Time Spent - 20 minutes Remaining Estimate - 10 minutes