castor

Add test of enum style classes to XML test suite

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.0.4
  • Fix Version/s: 1.0.5
  • Component/s: XML tests
  • Labels:
    None
  • Number of attachments :
    1

Issue Links

depends upon

Sub-task - The sub-task of the issue CASTOR-1672 Add to CTF test header the minimum JVM version for this test

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Ralf, it looks like we can only add one of the tests, as one of the tests makes use of Java 5 generics, right ?

Show
Werner Guttmann added a comment - Ralf, it looks like we can only add one of the tests, as one of the tests makes use of Java 5 generics, right ?
Hide
Permalink
Werner Guttmann added a comment -

Final patch.

Show
Werner Guttmann added a comment - Final patch.
Hide
Permalink
Edward Kuns added a comment -

We need to be able to run these sorts of tests... the CTF probably needs a way of containing Java 5 code but only running it when the current JVM is a Java 5 JVM.

Show
Edward Kuns added a comment - We need to be able to run these sorts of tests... the CTF probably needs a way of containing Java 5 code but only running it when the current JVM is a Java 5 JVM.
Hide
Permalink
Ralf Joachim added a comment -

Yes, you can only add one of the tests.

Show
Ralf Joachim added a comment - Yes, you can only add one of the tests.
Hide
Permalink
Ralf Joachim added a comment -

I don't see a possibility to include Java 5 test yet. The problem is not only that we need to omit them at execution, they also cause compile errors that I don't see a chance to omit.

Show
Ralf Joachim added a comment - I don't see a possibility to include Java 5 test yet. The problem is not only that we need to omit them at execution, they also cause compile errors that I don't see a chance to omit.
Hide
Permalink
Edward Kuns added a comment -

But it's compile errors during CTF execution and not at any other time. If the CTF just skpped those tests, it wouldn't even try to compile the code for those tests. It should be no problem.

Show
Edward Kuns added a comment - But it's compile errors during CTF execution and not at any other time. If the CTF just skpped those tests, it wouldn't even try to compile the code for those tests. It should be no problem.
Hide
Permalink
Ralf Joachim added a comment -

If only generated code contains Java 5 artefacts there is no problem from my point of view. At the test we are talking here we would have to add enum declarations into SVN which doesn't sound like a good idea to me. ATM I have no idea how we can handle these situations.

Show
Ralf Joachim added a comment - If only generated code contains Java 5 artefacts there is no problem from my point of view. At the test we are talking here we would have to add enum declarations into SVN which doesn't sound like a good idea to me. ATM I have no idea how we can handle these situations.
Hide
Permalink
Edward Kuns added a comment -

How to handle Java 5 code in CTF tests .... add a flag to the TestDescriptor.xml to indicate that this entire test case is Java-5 only. It has to be all-or-nothing. You cannot have a TestDescriptor.xml with one unit test that is Java 1.3 and another that is Java 5, because all of the code for a CTF test is either compiled or not. Buf if a full TestDescriptor.xml is Java 5 and all of the tests in that directory are Java 5, then that whole test can be disabled for those running under Java 1.4 and earlier.

That will avoid trying to compile Java 5 source under an earlier compiler.

I cannot see an easy (or reasonable) way to have one TestDescriptor.xml with two different unit tests where one unit test is Java 5 and the other is Java 1.4.

Show
Edward Kuns added a comment - How to handle Java 5 code in CTF tests .... add a flag to the TestDescriptor.xml to indicate that this entire test case is Java-5 only. It has to be all-or-nothing. You cannot have a TestDescriptor.xml with one unit test that is Java 1.3 and another that is Java 5, because all of the code for a CTF test is either compiled or not. Buf if a full TestDescriptor.xml is Java 5 and all of the tests in that directory are Java 5, then that whole test can be disabled for those running under Java 1.4 and earlier. That will avoid trying to compile Java 5 source under an earlier compiler. I cannot see an easy (or reasonable) way to have one TestDescriptor.xml with two different unit tests where one unit test is Java 5 and the other is Java 1.4.
Hide
Permalink
Werner Guttmann added a comment -

Hmm, given Edward's description, it looks doable to me (as long as this test directory with Java 5 specific sources never ends up on the build path. Edward, feel like showing us that it is doable indeed .. ?

Show
Werner Guttmann added a comment - Hmm, given Edward's description, it looks doable to me (as long as this test directory with Java 5 specific sources never ends up on the build path. Edward, feel like showing us that it is doable indeed .. ?
Hide
Permalink
Edward Kuns added a comment -

Absolutely. Now that I've delivered a big chunk of work on the CTF, I an ready to start something new.
See CASTOR-1672

Show
Edward Kuns added a comment - Absolutely. Now that I've delivered a big chunk of work on the CTF, I an ready to start something new. See CASTOR-1672
Hide
Permalink
Edward Kuns added a comment -

Adding a link (depends on) to the CTF Jira issue which will add the ability to specify a minimum JVM for a test.

Show
Edward Kuns added a comment - Adding a link (depends on) to the CTF Jira issue which will add the ability to specify a minimum JVM for a test.
Hide
Permalink
Werner Guttmann added a comment -

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Show
Werner Guttmann added a comment - Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Ralf Joachim
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
20m
Original Estimate - 20 minutes
Remaining:
20m
Remaining Estimate - 20 minutes
Logged:
Not Specified
Time Spent - Not Specified