castor

Unmarshalling enum field fails with type conversion error

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.4
  • Fix Version/s: 1.0.5
  • Component/s: XML
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    4

Description

Trying to unmarshal fails with the following exception under 1.0.4:

Type conversion error: could not set value of rank(castor.enumbug.Rank) with value of type java.lang.String

{file: [not available]; line: 5; column: 10}

at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:722)
at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:578)
at castor.enumbug.CardTest.testUnmarshal(CardTest.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.junit.internal.runners.TestMethodRunner.executeMethodBody(TestMethodRunner.java:99)
at org.junit.internal.runners.TestMethodRunner.runUnprotected(TestMethodRunner.java:81)
at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
at org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75)
at org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45)
at org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:71)
at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:35)
at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:38)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
Caused by: java.lang.IllegalArgumentException: Type conversion error: could not set value of rank(castor.enumbug.Rank) with value of type java.lang.String
at org.exolab.castor.mapping.loader.FieldHandlerImpl.setValue(FieldHandlerImpl.java:546)
at org.exolab.castor.mapping.GeneralizedFieldHandler.setValue(GeneralizedFieldHandler.java:274)
at org.exolab.castor.xml.UnmarshalHandler.endElement(UnmarshalHandler.java:1054)
at org.exolab.castor.xml.UnmarshalHandler.endElement(UnmarshalHandler.java:1121)
at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:708)
... 22 more
Caused by: java.lang.IllegalArgumentException: Type conversion error: could not set value of rank(castor.enumbug.Rank) with value of type java.lang.String
at org.exolab.castor.mapping.loader.FieldHandlerImpl.setValue(FieldHandlerImpl.java:546)
at org.exolab.castor.mapping.GeneralizedFieldHandler.setValue(GeneralizedFieldHandler.java:274)
at org.exolab.castor.xml.UnmarshalHandler.endElement(UnmarshalHandler.java:1054)
at org.exolab.castor.xml.UnmarshalHandler.endElement(UnmarshalHandler.java:1121)
at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:708)
at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:578)
at castor.enumbug.CardTest.testUnmarshal(CardTest.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.junit.internal.runners.TestMethodRunner.executeMethodBody(TestMethodRunner.java:99)
at org.junit.internal.runners.TestMethodRunner.runUnprotected(TestMethodRunner.java:81)
at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
at org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75)
at org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45)
at org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:71)
at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:35)
at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:38)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

Issue Links

relates to

Sub-task - The sub-task of the issue CASTOR-1584 Refactor AbstractMappingLoader

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Observation: why oh why at lines 589ff of XMLMappingLoader is the instantiation of new EnumFieldHandler() commented out ? Imho, this should be the cpode that we want to execute, and not the instantiation of a ToStringFieldHandler .. .

Show
Werner Guttmann added a comment - Observation: why oh why at lines 589ff of XMLMappingLoader is the instantiation of new EnumFieldHandler() commented out ? Imho, this should be the cpode that we want to execute, and not the instantiation of a ToStringFieldHandler .. .
Hide
Permalink
Ralf Joachim added a comment -

As far as I remember from my ongoing refactoring of MappingLoader's and ClassDescriptor's there is still some code that is intended to deal with enums that I actually do not know where it is. According to my ongoing refactoring in that area I think it will be better if I take a look at this myself before I need to search how your changes fit into my refactoring.

Having said that I would appreciate if you could add a test to XML test suite dealing with enums.

Show
Ralf Joachim added a comment - As far as I remember from my ongoing refactoring of MappingLoader's and ClassDescriptor's there is still some code that is intended to deal with enums that I actually do not know where it is. According to my ongoing refactoring in that area I think it will be better if I take a look at this myself before I need to search how your changes fit into my refactoring. Having said that I would appreciate if you could add a test to XML test suite dealing with enums.
Hide
Permalink
Werner Guttmann added a comment -

There you are .... (relative to src/bugs, as always)

Show
Werner Guttmann added a comment - There you are .... (relative to src/bugs, as always)
Hide
Permalink
Henk van Voorthujsen added a comment -

I took the time to do a binary search against the test case - the problem first seems to come up in revision 6305.
I hope that helps - the only real changes in that revision look to be to org.exolab.castor.mapping.loader.AbstractMappingLoader

Show
Henk van Voorthujsen added a comment - I took the time to do a binary search against the test case - the problem first seems to come up in revision 6305. I hope that helps - the only real changes in that revision look to be to org.exolab.castor.mapping.loader.AbstractMappingLoader
Hide
Permalink
Ralf Joachim added a comment -

That's what I feared has caused the problem, the refactoring of AbstractMappingLoader.

As far as it seams to me looking at the differences in fisheye (http://fisheye.codehaus.org/browse/castor/castor/trunk/src/main/java/org/exolab/castor/mapping/loader/AbstractMappingLoader.java?r1=6244&r2=6305), this may be caused by the changes from lines 567-598 pre patch to 607-614 post patch.

Show
Ralf Joachim added a comment - That's what I feared has caused the problem, the refactoring of AbstractMappingLoader. As far as it seams to me looking at the differences in fisheye ( http://fisheye.codehaus.org/browse/castor/castor/trunk/src/main/java/org/exolab/castor/mapping/loader/AbstractMappingLoader.java?r1=6244&r2=6305 ), this may be caused by the changes from lines 567-598 pre patch to 607-614 post patch.
Hide
Permalink
Werner Guttmann added a comment -

How come it is so hard to understand what's been going on through FishEye ... ? I think we should (whatever we decide to do) add a new test case to the master test suite for ENUMs.

Show
Werner Guttmann added a comment - How come it is so hard to understand what's been going on through FishEye ... ? I think we should (whatever we decide to do) add a new test case to the master test suite for ENUMs.
Hide
Permalink
M.-Leander Reimer added a comment -

The method public static

{Type}

valueOf(String) not working with 1.0.4 for enum style classes.

The attached ZIP contains a junit test and required classes, mapping XML and data XML files.

In 1.0.4 the unmarshalling of a enum style class using a field handler works, however, with the current SVN head even this is not working anymore.

Show
M.-Leander Reimer added a comment - The method public static {Type} valueOf(String) not working with 1.0.4 for enum style classes. The attached ZIP contains a junit test and required classes, mapping XML and data XML files. In 1.0.4 the unmarshalling of a enum style class using a field handler works, however, with the current SVN head even this is not working anymore.
Hide
Permalink
Ralf Joachim added a comment -

I first tried with enum style class from Leander and found the failure that broke unmarshalling. At line 660 of AbstractMappingLoader

if (returnType != null)

{ return null; }

which has to be

if (returnType == null) { return null; }

The second problem mentioned by Leander has not been one of castor but one of the test case Line 117 of DocumentVersion

} else if (ADDOCUMENT_1_0_XML_VALUE.equals(value))

{ should be }

else if (ADDOCUMENT_1_1_XML_VALUE.equals(value)) {

Will try Java 5 enum test from Henk next.

Show
Ralf Joachim added a comment - I first tried with enum style class from Leander and found the failure that broke unmarshalling. At line 660 of AbstractMappingLoader if (returnType != null) { return null; } which has to be if (returnType == null) { return null; } The second problem mentioned by Leander has not been one of castor but one of the test case Line 117 of DocumentVersion } else if (ADDOCUMENT_1_0_XML_VALUE.equals(value)) { should be } else if (ADDOCUMENT_1_1_XML_VALUE.equals(value)) { Will try Java 5 enum test from Henk next.
Hide
Permalink
Ralf Joachim added a comment -

Patch containing the fix and both junit tests relative to src/bugs.

Show
Ralf Joachim added a comment - Patch containing the fix and both junit tests relative to src/bugs.
Hide
Permalink
Werner Guttmann added a comment -

Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.

Show
Werner Guttmann added a comment - Bulk-closing all issues assigned to 1.0.5. Please feel free to re-open any of those when required.
Hide
Permalink
Joe Littlejohn added a comment -

What's the status of this? The bug still seems to be present in 1.1.2.1.

The commented out code is at XMLMappingLoader:668 and causes the following stack trace:

java.lang.IllegalArgumentException: Type conversion error: could not set value of vendor(upgrade.model.Vendor) with value of type java.lang.String
at org.exolab.castor.mapping.loader.FieldHandlerImpl.setValue(FieldHandlerImpl.java:521)
at org.exolab.castor.mapping.GeneralizedFieldHandler.setValue(GeneralizedFieldHandler.java:274)
at org.exolab.castor.xml.UnmarshalHandler.processAttribute(UnmarshalHandler.java:3026)
at org.exolab.castor.xml.UnmarshalHandler.processAttributes(UnmarshalHandler.java:2676)
at org.exolab.castor.xml.UnmarshalHandler.startElement(UnmarshalHandler.java:2314)
at org.exolab.castor.xml.UnmarshalHandler.startElement(UnmarshalHandler.java:1353)
at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:709)
...

I have a Java 5 enum upgrade.model.Vendor and castor does correctly use the valueOf method to get the enum value, however the ToStringFieldHandler uses a toString before calling the setter, and the invocation then fails.

Show
Joe Littlejohn added a comment - What's the status of this? The bug still seems to be present in 1.1.2.1. The commented out code is at XMLMappingLoader:668 and causes the following stack trace: java.lang.IllegalArgumentException: Type conversion error: could not set value of vendor(upgrade.model.Vendor) with value of type java.lang.String at org.exolab.castor.mapping.loader.FieldHandlerImpl.setValue(FieldHandlerImpl.java:521) at org.exolab.castor.mapping.GeneralizedFieldHandler.setValue(GeneralizedFieldHandler.java:274) at org.exolab.castor.xml.UnmarshalHandler.processAttribute(UnmarshalHandler.java:3026) at org.exolab.castor.xml.UnmarshalHandler.processAttributes(UnmarshalHandler.java:2676) at org.exolab.castor.xml.UnmarshalHandler.startElement(UnmarshalHandler.java:2314) at org.exolab.castor.xml.UnmarshalHandler.startElement(UnmarshalHandler.java:1353) at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) at org.exolab.castor.xml.Unmarshaller.unmarshal(Unmarshaller.java:709) ... I have a Java 5 enum upgrade.model.Vendor and castor does correctly use the valueOf method to get the enum value, however the ToStringFieldHandler uses a toString before calling the setter, and the invocation then fails.
Hide
Permalink
Joe Littlejohn added a comment -

Sorry my mistake. mapping.xml was wrong (type attribute had been added to bind-xml element, and not on the field element).

Show
Joe Littlejohn added a comment - Sorry my mistake. mapping.xml was wrong (type attribute had been added to bind-xml element, and not on the field element).
Hide
Permalink
Werner Guttmann added a comment -

Thanks for the feedback

Show
Werner Guttmann added a comment - Thanks for the feedback

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Henk van Voorthujsen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
20m
Original Estimate - 20 minutes
Remaining:
20m
Remaining Estimate - 20 minutes
Logged:
Not Specified
Time Spent - Not Specified